debug ci failures

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

.github/workflows/ci.yml

@@ -113,13 +113,46 @@ jobs:
       - name: Test plotly and plotly_static
         shell: bash
         run: |
+          echo "=== Platform Information ==="
+          echo "OS: $(uname -a)"
+          echo "Architecture: $(uname -m)"
+          echo "Current directory: $(pwd)"
+          
+          echo "=== Checking for existing processes ==="
+          ps aux | grep -E "(chromedriver|geckodriver|firefox|chrome)" || echo "No browser processes found"
+          
+          echo "=== Checking port availability ==="
+          netstat -an | grep -E ":(4444|4445|4446|4447|4448|4449|4450)" || echo "No WebDriver ports in use"
+          
+          echo "=== Running tests ==="
           if [ "${{ matrix.browser }}" = "firefox" ]; then
-            cargo test -p plotly --features static_export_default --lib
-            cargo test -p plotly_static --features geckodriver,webdriver_download
+            echo "Testing with Firefox/geckodriver..."
+            echo "=== Firefox Environment Check ==="
+            echo "Firefox version: $(firefox --version 2>/dev/null || echo 'Firefox not found in PATH')"
+            echo "geckodriver version: $(geckodriver --version 2>/dev/null || echo 'geckodriver not found in PATH')"
+            echo "Available memory: $(free -h 2>/dev/null || echo 'free command not available')"
+            echo "Available disk space: $(df -h . 2>/dev/null || echo 'df command not available')"
+            
+            echo "=== Testing plotly with Firefox ==="
+            timeout 600 cargo test -p plotly --features static_export_default --lib -- --nocapture
+            
+            echo "=== Testing plotly_static with Firefox ==="
+            timeout 600 cargo test -p plotly_static --features geckodriver,webdriver_download -- --nocapture
           else
-            cargo test -p plotly --features static_export_chromedriver,static_export_downloader --lib
-            cargo test -p plotly_static --features chromedriver,webdriver_download
+            echo "Testing with Chrome/chromedriver..."
+            echo "=== Chrome Environment Check ==="
+            echo "Chrome version: $(google-chrome --version 2>/dev/null || echo 'Chrome not found in PATH')"
+            echo "chromedriver version: $(chromedriver --version 2>/dev/null || echo 'chromedriver not found in PATH')"
+            
+            timeout 600 cargo test -p plotly --features static_export_chromedriver,static_export_downloader --lib -- --nocapture
+            timeout 600 cargo test -p plotly_static --features chromedriver,webdriver_download -- --nocapture
           fi
+          
+          echo "=== Cleanup after tests ==="
+          pkill -f chromedriver || echo "No chromedriver processes to kill"
+          pkill -f geckodriver || echo "No geckodriver processes to kill"
+          pkill -f firefox || echo "No firefox processes to kill"
+          pkill -f chrome || echo "No chrome processes to kill"
 
   test-macos-compatibility:
     name: Test macOS Compatibility
@@ -186,6 +219,15 @@ jobs:
           
           echo "=== Testing user data directory management ==="
           cargo test -p plotly_static --features chromedriver,webdriver_download --lib macos_tests::macos_tests::test_user_data_directory_management -- --nocapture || echo "User data directory management test failed"
+          
+          echo "=== Testing PDF debugging ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib macos_tests::macos_tests::test_pdf_debugging_macos -- --nocapture || echo "PDF debugging test failed"
+          
+          echo "=== Testing PDF with alternative flags ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib macos_tests::macos_tests::test_pdf_with_alternative_flags -- --nocapture || echo "PDF alternative flags test failed"
+          
+          echo "=== Testing html2pdf library availability ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib macos_tests::macos_tests::test_html2pdf_library_loading -- --nocapture || echo "html2pdf library test failed"
       
       - name: Run all plotly_static tests on macOS
         run: |
@@ -214,6 +256,106 @@ jobs:
           pkill -f chromedriver || echo "No chromedriver processes to kill"
           pkill -f "Google Chrome" || echo "No Chrome processes to kill"
 
+  test-windows-compatibility:
+    name: Test Windows Compatibility
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
+      
+      - uses: dtolnay/rust-toolchain@stable
+      
+      - name: Test Chrome and chromedriver installation
+        shell: cmd
+        run: |
+          echo "=== System Information ==="
+          echo "OS: %OS%"
+          echo "Architecture: %PROCESSOR_ARCHITECTURE%"
+          echo "PATH: %PATH%"
+          echo "Current user: %USERNAME%"
+          echo "Home directory: %USERPROFILE%"
+          
+          echo "=== Chrome Installation Check ==="
+          dir "C:\Program Files\Google\Chrome\Application\chrome.exe" 2>nul || echo "Chrome not found in Program Files"
+          where google-chrome 2>nul || echo "Chrome not found in PATH"
+          google-chrome --version 2>nul || echo "Chrome version check failed"
+          
+          echo "=== chromedriver Installation Check ==="
+          chromedriver --version 2>nul || echo "chromedriver not found in PATH"
+          dir "C:\Program Files\Google\Chrome\Application\chromedriver.exe" 2>nul || echo "chromedriver not found in Program Files"
+          
+          echo "=== Environment Variables ==="
+          echo "WEBDRIVER_PATH: %WEBDRIVER_PATH%"
+          echo "CHROMEDRIVER_PATH: %CHROMEDRIVER_PATH%"
+          echo "CHROME_PATH: %CHROME_PATH%"
+      
+      - name: Run Windows-specific tests
+        shell: cmd
+        run: |
+          echo "Running Windows compatibility tests..."
+          echo "Current directory: %CD%"
+          echo "Rust version: %RUST_VERSION%"
+          echo "Cargo version: %CARGO_VERSION%"
+          
+          echo "=== Testing Chrome installation ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_chrome_installation -- --nocapture
+          
+          echo "=== Testing chromedriver installation ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_chromedriver_installation -- --nocapture
+          
+          echo "=== Testing static exporter creation ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_static_exporter_creation_windows -- --nocapture
+          
+          echo "=== Testing basic PNG export ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_basic_png_export_windows -- --nocapture
+          
+          echo "=== Testing Windows Chrome flags ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_windows_chrome_flags -- --nocapture
+          
+          echo "=== Testing user data directory management ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_user_data_directory_management -- --nocapture
+          
+          echo "=== Testing PDF debugging ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_pdf_debugging_windows -- --nocapture
+          
+          echo "=== Testing PDF with alternative flags ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib windows_tests::windows_tests::test_pdf_with_alternative_flags -- --nocapture
+      
+      - name: Run all plotly_static tests on Windows
+        shell: cmd
+        run: |
+          echo "Running all plotly_static tests on Windows..."
+          echo "Checking for existing chromedriver processes before tests..."
+          tasklist /FI "IMAGENAME eq chromedriver.exe" 2>nul || echo "No chromedriver processes found"
+          
+          echo "=== Running tests ==="
+          cargo test -p plotly_static --features chromedriver,webdriver_download --lib -- --nocapture
+          
+          echo "Checking for chromedriver processes after tests..."
+          tasklist /FI "IMAGENAME eq chromedriver.exe" 2>nul || echo "No chromedriver processes found"
+      
+      - name: Test plotly with static export on Windows
+        shell: cmd
+        run: |
+          echo "Testing plotly with static export on Windows..."
+          echo "Checking for port conflicts before tests..."
+          netstat -an | findstr ":4444" || echo "Port 4444 is free"
+          netstat -an | findstr ":4445" || echo "Port 4445 is free"
+          netstat -an | findstr ":4446" || echo "Port 4446 is free"
+          netstat -an | findstr ":4447" || echo "Port 4447 is free"
+          
+          echo "=== Running plotly static export tests ==="
+          cargo test -p plotly --features static_export_chromedriver,static_export_downloader --lib -- --nocapture
+          
+          echo "Cleaning up after tests..."
+          taskkill /F /IM chromedriver.exe 2>nul || echo "No chromedriver processes to kill"
+          taskkill /F /IM chrome.exe 2>nul || echo "No Chrome processes to kill"
+
   code-coverage:
     name: Code Coverage
     runs-on: ubuntu-latest

plotly_static/src/lib.rs

@@ -261,7 +261,8 @@ use webdriver::WebDriver;
 
 use crate::template::{IMAGE_EXPORT_JS_SCRIPT, PDF_EXPORT_JS_SCRIPT};
 
-const DEFAULT_CAPS_ARRAY: [&str; 20] = [
+#[cfg(feature = "chromedriver")]
+const CHROME_DEFAULT_CAPS: [&str; 23] = [
     "--headless",
     "--no-sandbox",
     "--disable-gpu-sandbox",
@@ -280,9 +281,19 @@ const DEFAULT_CAPS_ARRAY: [&str; 20] = [
     "--password-store=basic",
     "--disable-web-security",
     "--disable-breakpad",
-    "--allow-file-access-from-files",
     "--no-first-run",
     "--no-default-browser-check",
+    // Additional flags for better PDF generation support
+    "--disable-backgrounding-occluded-windows",
+    "--disable-ipc-flooding-protection",
+    "--enable-logging",
+    "--v=1",
+];
+
+#[cfg(feature = "geckodriver")]
+const FIREFOX_DEFAULT_CAPS: [&str; 2] = [
+    "-headless",   // Essential for headless operation (single dash for Firefox)
+    "--no-remote", // Prevents connecting to existing Firefox instances
 ];
 
 mod template;
@@ -292,6 +303,10 @@ mod webdriver;
 #[cfg(target_os = "macos")]
 mod macos_tests;
 
+#[cfg(test)]
+#[cfg(target_os = "windows")]
+mod windows_tests;
+
 /// Supported image formats for static image export.
 ///
 /// This enum defines all the image formats that can be exported from Plotly
@@ -438,7 +453,20 @@ impl Default for StaticExporterBuilder {
             webdriver_url: webdriver::WEBDRIVER_URL.to_string(),
             spawn_webdriver: true,
             offline_mode: false,
-            webdriver_browser_caps: DEFAULT_CAPS_ARRAY.iter().map(|s| s.to_string()).collect(),
+            webdriver_browser_caps: {
+                #[cfg(feature = "chromedriver")]
+                {
+                    CHROME_DEFAULT_CAPS.iter().map(|s| s.to_string()).collect()
+                }
+                #[cfg(feature = "geckodriver")]
+                {
+                    FIREFOX_DEFAULT_CAPS.iter().map(|s| s.to_string()).collect()
+                }
+                #[cfg(not(any(feature = "chromedriver", feature = "geckodriver")))]
+                {
+                    Vec::new()
+                }
+            },
         }
     }
 }
@@ -995,7 +1023,12 @@ impl StaticExporter {
             .as_ref()
             .expect("user_data_dir should be set");
         let mut browser_args = self.webdriver_browser_caps.clone();
-        browser_args.push(format!("--user-data-dir={}", user_data_dir.display()));
+        
+        // Only add --user-data-dir for Chrome (Firefox doesn't support this flag)
+        #[cfg(feature = "chromedriver")]
+        {
+            browser_args.push(format!("--user-data-dir={}", user_data_dir.display()));
+        }
 
         browser_opts.insert("args".to_string(), serde_json::json!(browser_args));