apply clippy and fmt fixes

 - add extra diagonstics and debug info to webdriver code

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

.github/workflows/ci.yml

@@ -33,14 +33,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
       - uses: dtolnay/rust-toolchain@stable
         with:
           components: clippy
           targets: wasm32-unknown-unknown
       # lint the main library workspace for non-wasm target
-      - run: cargo clippy --all-features -- -D warnings
+      - run: cargo clippy --features all -- -D warnings -A deprecated
       # lint the non-wasm examples
-      - run: cd ${{ github.workspace }}/examples && cargo clippy --workspace --exclude "wasm*" -- -D warnings
+      - run: cd ${{ github.workspace }}/examples && cargo clippy --workspace --exclude "wasm*" --exclude "kaleido" -- -D warnings
       # lint the plotly library for wasm target
       - run: cargo clippy --package plotly --target wasm32-unknown-unknown -- -D warnings
       # lint the wasm examples
@@ -68,9 +73,14 @@ jobs:
         os: [ubuntu-latest, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
     steps:
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
-      - run: cargo test --features plotly_ndarray,plotly_image,kaleido
+      - run: cargo test --workspace --features plotly_ndarray,plotly_image,static_export_default --exclude plotly_kaleido
       - if: ${{ matrix.os == 'windows-latest' }}
         run: gci -recurse -filter "*example*"
 
@@ -103,12 +113,21 @@ jobs:
           ndarray,
           scientific_charts,
           shapes,
+          static_export,
           subplots,
           themes,
         ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      
+      - name: Setup Chrome (for static_export)
+        if: matrix.example == 'static_export'
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
+    
       - uses: dtolnay/rust-toolchain@stable
       - run: cd ${{ github.workspace }}/examples/${{ matrix.example }} && cargo build
 
@@ -131,6 +150,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      
+      - name: Setup Chrome (for static_export)
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
+      
       - uses: dtolnay/rust-toolchain@stable
       - run: cargo install mdbook --no-default-features --features search --vers "^0.4" --locked --quiet
       - name: Build examples to generate needed html files
@@ -143,5 +169,6 @@ jobs:
           cd ${{ github.workspace }}/examples/subplots && cargo run
           cd ${{ github.workspace }}/examples/shapes && cargo run
           cd ${{ github.workspace }}/examples/themes && cargo run
+          cd ${{ github.workspace }}/examples/static_export && cargo run
       - name: Build book 
-        run: mdbook build docs/book
+        run: mdbook build docs/book

README.md

@@ -53,7 +53,6 @@ A plotting library for Rust powered by [Plotly.js](https://plot.ly/javascript/).
 
 Documentation and numerous interactive examples are available in the [Plotly.rs Book](https://plotly.github.io/plotly.rs/content/getting_started.html), the [examples/](https://github.com/plotly/plotly.rs/tree/main/examples) directory and [docs.rs](https://docs.rs/crate/plotly).
 
-
 For changes since the last version, please consult the [changelog](https://github.com/plotly/plotly.rs/tree/main/CHANGELOG.md).
 
 # Basic Usage
@@ -62,7 +61,7 @@ Add this to your `Cargo.toml`:
 
 ```toml
 [dependencies]
-plotly = "0.12"
+plotly = "0.13"
 ```
 
 ## Exporting a single Interactive Plot
@@ -114,7 +113,7 @@ The recommended way to export static images is using the `plotly_static` backend
 
 ```toml
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_default"] }
+plotly = { version = "0.13", features = ["static_export_default"] }
 ```
 
 This supports PNG, JPEG, WEBP, SVG, and PDF formats:
@@ -141,7 +140,7 @@ Enable the `kaleido` feature and opt in for automatic downloading of the `kaleid
 # Cargo.toml
 
 [dependencies]
-plotly = { version = "0.12", features = ["kaleido", "kaleido_download"] }
+plotly = { version = "0.13", features = ["kaleido", "kaleido_download"] }
 ```
 
 Alternatively, enable only the `kaleido` feature and manually install Kaleido.

docs/book/src/fundamentals/static_image_export.md

@@ -16,22 +16,22 @@ The static export functionality is controlled by feature flags in the main `plot
 
 ### Optional Features:
 - `static_export_downloader`: Automatically downloads WebDriver binaries at build time
-- `static_export_default`: Convenience feature that includes geckodriver + downloader
+- `static_export_default`: Convenience feature that includes chromedriver + downloader
 
 ### Cargo.toml Configuration Examples:
 
 ```toml
 # Basic usage with manual WebDriver installation
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_chromedriver"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver"] }
 
 # With automatic WebDriver download
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_chromedriver", "static_export_downloader"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
 
 # Recommended: Default configuration with Firefox + auto-download
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_default"] }
+plotly = { version = "0.13", features = ["static_export_default"] }
 ```
 
 ## Prerequisites

docs/book/src/getting_started.md

@@ -22,7 +22,7 @@ To start using [plotly.rs](https://github.com/plotly/plotly.rs) in your project
 
 ```toml
 [dependencies]
-plotly = "0.12"
+plotly = "0.13"
 ```
 
 [Plotly.rs](https://github.com/plotly/plotly.rs) is ultimately a thin wrapper around the `plotly.js` library. The main job of this library is to provide `structs` and `enums` which get serialized to `json` and passed to the `plotly.js` library to actually do the heavy lifting. As such, if you are familiar with `plotly.js` or its derivatives (e.g. the equivalent Python library), then you should find [`plotly.rs`](https://github.com/plotly/plotly.rs) intuitive to use.

examples/static_export/README.md

@@ -24,20 +24,20 @@ The `plotly_static` crate provides a high-level interface for converting Plotly
 
 The example uses `static_export_default` which includes:
 - `plotly_static`: Core static export functionality
-- `plotly_static/geckodriver`: Firefox WebDriver support
+- `plotly_static/chromedriver`: Chrome WebDriver support
 - `plotly_static/webdriver_download`: Automatic WebDriver download
 
 ### Alternative Configurations
 
 ```toml
 # Use Chrome/Chromium instead of Firefox
-plotly = { version = "0.12", features = ["static_export_chromedriver", "static_export_downloader"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
 
 # Manual WebDriver installation (no automatic download)
-plotly = { version = "0.12", features = ["static_export_geckodriver"] }
+plotly = { version = "0.13", features = ["static_export_geckodriver"] }
 
 # Chrome with manual installation
-plotly = { version = "0.12", features = ["static_export_chromedriver"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver"] }
 ```
 
 ## Running the Example
@@ -92,4 +92,4 @@ Set `RUST_LOG=debug` to see detailed WebDriver operations and troubleshooting in
 - [plotly_static crate documentation](https://docs.rs/plotly_static/)
 - [WebDriver specification](https://w3c.github.io/webdriver/)
 - [GeckoDriver documentation](https://firefox-source-docs.mozilla.org/testing/geckodriver/)
-- [ChromeDriver documentation](https://chromedriver.chromium.org/) 
+- [ChromeDriver documentation](https://chromedriver.chromium.org/) 

plotly/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "plotly"
-version = "0.12.1"
+version = "0.13.0"
 description = "A plotting library powered by Plotly.js"
 authors = ["Ioannis Giagkiozis <[email protected]>", "Andrei Gherghescu <[email protected]>"]
 license = "MIT"
@@ -22,7 +22,10 @@ kaleido_download = ["plotly_kaleido/download"]
 static_export_downloader = ["plotly_static/webdriver_download"]
 static_export_chromedriver = ["plotly_static", "plotly_static/chromedriver"]
 static_export_geckodriver = ["plotly_static", "plotly_static/geckodriver"]
-static_export_default = ["plotly_static", "plotly_static/geckodriver", "plotly_static/webdriver_download"]
+static_export_default = ["plotly_static", "plotly_static/chromedriver", "plotly_static/webdriver_download"]
+
+# All non-conflicting features
+all = ["plotly_ndarray", "plotly_image", "plotly_embed_js", "static_export_default"]
 
 plotly_ndarray = ["ndarray"]
 plotly_image = ["image"]
@@ -33,7 +36,7 @@ askama = { version = "0.14.0", features = ["serde_json"] }
 dyn-clone = "1"
 erased-serde = "0.4"
 image = { version = "0.25", optional = true }
-plotly_derive = { version = "0.12", path = "../plotly_derive" }
+plotly_derive = { version = "0.13", path = "../plotly_derive" }
 plotly_static = { version = "0.0.1", path = "../plotly_static", optional = true }
 plotly_kaleido = { version = "0.12", path = "../plotly_kaleido", optional = true }
 ndarray = { version = "0.16", optional = true }

plotly/src/layout/mod.rs

@@ -65,19 +65,19 @@ impl std::fmt::Display for ControlBuilderError {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             ControlBuilderError::RestyleSerializationError(e) => {
-                write!(f, "Failed to serialize restyle: {}", e)
+                write!(f, "Failed to serialize restyle: {e}")
             }
             ControlBuilderError::RelayoutSerializationError(e) => {
-                write!(f, "Failed to serialize relayout: {}", e)
+                write!(f, "Failed to serialize relayout: {e}")
             }
             ControlBuilderError::ValueSerializationError(e) => {
-                write!(f, "Failed to serialize value: {}", e)
+                write!(f, "Failed to serialize value: {e}")
             }
             ControlBuilderError::InvalidRestyleObject(s) => {
-                write!(f, "Invalid restyle object: expected object but got {}", s)
+                write!(f, "Invalid restyle object: expected object but got {s}")
             }
             ControlBuilderError::InvalidRelayoutObject(s) => {
-                write!(f, "Invalid relayout object: expected object but got {}", s)
+                write!(f, "Invalid relayout object: expected object but got {s}")
             }
         }
     }

plotly/src/plot.rs

@@ -233,7 +233,7 @@ impl Plot {
         let mut temp = env::temp_dir();
         let mut plot_name = Alphanumeric.sample_string(&mut rng(), 22);
         plot_name.push_str(".html");
-        plot_name = format!("plotly_{}", plot_name);
+        plot_name = format!("plotly_{plot_name}");
         temp.push(plot_name);
 
         // Save the rendered plot to the temp file.
@@ -276,7 +276,7 @@ impl Plot {
         let mut temp = env::temp_dir();
         let mut plot_name = Alphanumeric.sample_string(&mut rng(), 22);
         plot_name.push_str(".html");
-        plot_name = format!("plotly_{}", plot_name);
+        plot_name = format!("plotly_{plot_name}");
         temp.push(plot_name);
 
         // Save the rendered plot to the temp file.
@@ -350,18 +350,14 @@ impl Plot {
     /// Display plot in Jupyter Notebook.
     pub fn notebook_display(&self) {
         let plot_data = self.to_jupyter_notebook_html();
-        println!(
-            "EVCXR_BEGIN_CONTENT text/html\n{}\nEVCXR_END_CONTENT",
-            plot_data
-        );
+        println!("EVCXR_BEGIN_CONTENT text/html\n{plot_data}\nEVCXR_END_CONTENT");
     }
 
     /// Display plot in Jupyter Lab.
     pub fn lab_display(&self) {
         let plot_data = self.to_json();
         println!(
-            "EVCXR_BEGIN_CONTENT application/vnd.plotly.v1+json\n{}\nEVCXR_END_CONTENT",
-            plot_data
+            "EVCXR_BEGIN_CONTENT application/vnd.plotly.v1+json\n{plot_data}\nEVCXR_END_CONTENT"
         );
     }
 
@@ -487,7 +483,7 @@ impl Plot {
     ) -> Result<(), Box<dyn std::error::Error>> {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .build()
-            .map_err(|e| format!("Failed to create StaticExporter: {}", e))?;
+            .map_err(|e| format!("Failed to create StaticExporter: {e}"))?;
         self.write_image_with_exporter(&mut exporter, filename, format, width, height, scale)
     }
 
@@ -515,7 +511,7 @@ impl Plot {
     ) -> Result<String, Box<dyn std::error::Error>> {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .build()
-            .map_err(|e| format!("Failed to create StaticExporter: {}", e))?;
+            .map_err(|e| format!("Failed to create StaticExporter: {e}"))?;
         self.to_base64_with_exporter(&mut exporter, format, width, height, scale)
     }
 
@@ -538,7 +534,7 @@ impl Plot {
     ) -> Result<String, Box<dyn std::error::Error>> {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .build()
-            .map_err(|e| format!("Failed to create StaticExporter: {}", e))?;
+            .map_err(|e| format!("Failed to create StaticExporter: {e}"))?;
         self.to_svg_with_exporter(&mut exporter, width, height, scale)
     }
 
@@ -752,9 +748,8 @@ impl Plot {
         let local_plotly_js = include_str!("../resource/plotly.min.js");
 
         format!(
-            "<script type=\"text/javascript\">{}</script>\n
-            <script type=\"text/javascript\">{}</script>\n",
-            local_plotly_js, local_tex_svg_js,
+            "<script type=\"text/javascript\">{local_plotly_js}</script>\n
+            <script type=\"text/javascript\">{local_tex_svg_js}</script>\n",
         )
         .to_string()
     }

plotly_derive/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "plotly_derive"
-version = "0.12.1"
+version = "0.13.0"
 description = "Internal proc macro crate for Plotly-rs."
 authors = ["Ioannis Giagkiozis <[email protected]>"]
 license = "MIT"

plotly_derive/src/field_setter.rs

@@ -10,7 +10,7 @@ pub(crate) fn field_setter_impl(input: DeriveInput) -> proc_macro::TokenStream {
         Ok(r) => r,
         Err(e) => {
             return proc_macro::TokenStream::from(
-                darling::Error::custom(format!("{}. {}", UNSUPPORTED_ERROR, e)).write_errors(),
+                darling::Error::custom(format!("{UNSUPPORTED_ERROR}. {e}")).write_errors(),
             )
         }
     };
@@ -263,8 +263,7 @@ impl FieldReceiver {
                 // Require a default
                 assert!(
                     self.default.is_some(),
-                    "Please provide #[field_setter(default=\"..\") for the field {}",
-                    field_ident
+                    "Please provide #[field_setter(default=\"..\") for the field {field_ident}"
                 );
                 let val: proc_macro2::TokenStream = self.default.as_ref().unwrap().parse().unwrap();
                 quote![
@@ -380,7 +379,7 @@ impl FieldReceiver {
                     }
                 }
                 let variant_name = Ident::new(
-                    &format!("Modify{}", variant_name),
+                    &format!("Modify{variant_name}"),
                     proc_macro2::Span::call_site(),
                 );
                 let serde_attrs = self.serde();
@@ -425,13 +424,13 @@ impl FieldReceiver {
         }) = &modify_enum
         {
             let modify_ident = Ident::new(
-                &format!("modify_{}", field_ident),
+                &format!("modify_{field_ident}"),
                 proc_macro2::Span::call_site(),
             );
             match kind {
                 Kind::Trace => {
                     let modify_all_ident = Ident::new(
-                        &format!("modify_all_{}", field_ident),
+                        &format!("modify_all_{field_ident}"),
                         proc_macro2::Span::call_site(),
                     );
 
@@ -467,7 +466,7 @@ impl FieldReceiver {
         let array_setter = match field_type {
             FieldType::OptionDimString | FieldType::OptionDimOther(..) => {
                 let array_ident = Ident::new(
-                    &format!("{}_array", field_ident),
+                    &format!("{field_ident}_array"),
                     proc_macro2::Span::call_site(),
                 );
                 quote! {