add ci using static crate

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

.github/workflows/ci.yml

@@ -33,14 +33,20 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
+          install-dependencies: true
       - uses: dtolnay/rust-toolchain@stable
         with:
           components: clippy
           targets: wasm32-unknown-unknown
       # lint the main library workspace for non-wasm target
-      - run: cargo clippy --all-features -- -D warnings
+      - run: cargo clippy --features all -- -D warnings -A deprecated
       # lint the non-wasm examples
-      - run: cd ${{ github.workspace }}/examples && cargo clippy --workspace --exclude "wasm*" -- -D warnings
+      - run: cd ${{ github.workspace }}/examples && cargo clippy --workspace --exclude "wasm*" --exclude "kaleido" -- -D warnings
       # lint the plotly library for wasm target
       - run: cargo clippy --package plotly --target wasm32-unknown-unknown -- -D warnings
       # lint the wasm examples
@@ -68,12 +74,56 @@ jobs:
         os: [ubuntu-latest, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
     steps:
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
+          install-dependencies: true
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
-      - run: cargo test --features plotly_ndarray,plotly_image,kaleido
+      - run: cargo test --features plotly_ndarray,plotly_image,static_export_default
       - if: ${{ matrix.os == 'windows-latest' }}
         run: gci -recurse -filter "*example*"
 
+  test-static-export:
+    name: Test Static Export
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        browser: [firefox, chrome]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Setup Firefox
+        if: matrix.browser == 'firefox'
+        uses: browser-actions/setup-firefox@v1
+        with:
+          firefox-version: 'latest'
+      
+      - name: Setup Chrome
+        if: matrix.browser == 'chrome'
+        uses: browser-actions/setup-chrome@v1
+        with:
+          chrome-version: 'latest'
+          install-chromedriver: true
+          install-dependencies: true
+      
+      - uses: dtolnay/rust-toolchain@stable
+      
+      - name: Test plotly and plotly_static
+        shell: bash
+        run: |
+          if [ "${{ matrix.browser }}" = "firefox" ]; then
+            cargo test --features static_export_default --lib
+            cd plotly_static && cargo test --features geckodriver,webdriver_download
+          else
+            cargo test --features static_export_chromedriver,static_export_downloader --lib
+            cd plotly_static && cargo test --features chromedriver,webdriver_download
+          fi
+
   code-coverage:
     name: Code Coverage
     runs-on: ubuntu-latest
@@ -103,12 +153,20 @@ jobs:
           ndarray,
           scientific_charts,
           shapes,
+          static_export,
           subplots,
           themes,
         ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      
+      - name: Setup Firefox (for static_export)
+        if: matrix.example == 'static_export'
+        uses: browser-actions/setup-firefox@v1
+        with:
+          firefox-version: 'latest'
+      
       - uses: dtolnay/rust-toolchain@stable
       - run: cd ${{ github.workspace }}/examples/${{ matrix.example }} && cargo build
 
@@ -131,6 +189,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      
+      - name: Setup Firefox (for static_export example)
+        uses: browser-actions/setup-firefox@v1
+        with:
+          firefox-version: 'latest'
+      
       - uses: dtolnay/rust-toolchain@stable
       - run: cargo install mdbook --no-default-features --features search --vers "^0.4" --locked --quiet
       - name: Build examples to generate needed html files
@@ -143,5 +207,6 @@ jobs:
           cd ${{ github.workspace }}/examples/subplots && cargo run
           cd ${{ github.workspace }}/examples/shapes && cargo run
           cd ${{ github.workspace }}/examples/themes && cargo run
+          cd ${{ github.workspace }}/examples/static_export && cargo run
       - name: Build book 
         run: mdbook build docs/book

README.md

@@ -61,7 +61,7 @@ Add this to your `Cargo.toml`:
 
 ```toml
 [dependencies]
-plotly = "0.12"
+plotly = "0.13"
 ```
 
 ## Exporting a single Interactive Plot
@@ -113,7 +113,7 @@ The recommended way to export static images is using the `plotly_static` backend
 
 ```toml
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_default"] }
+plotly = { version = "0.13", features = ["static_export_default"] }
 ```
 
 This supports PNG, JPEG, WEBP, SVG, and PDF formats:
@@ -140,7 +140,7 @@ Enable the `kaleido` feature and opt in for automatic downloading of the `kaleid
 # Cargo.toml
 
 [dependencies]
-plotly = { version = "0.12", features = ["kaleido", "kaleido_download"] }
+plotly = { version = "0.13", features = ["kaleido", "kaleido_download"] }
 ```
 
 Alternatively, enable only the `kaleido` feature and manually install Kaleido.

docs/book/src/fundamentals/static_image_export.md

@@ -16,22 +16,22 @@ The static export functionality is controlled by feature flags in the main `plot
 
 ### Optional Features:
 - `static_export_downloader`: Automatically downloads WebDriver binaries at build time
-- `static_export_default`: Convenience feature that includes geckodriver + downloader
+- `static_export_default`: Convenience feature that includes chromedriver + downloader
 
 ### Cargo.toml Configuration Examples:
 
 ```toml
 # Basic usage with manual WebDriver installation
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_chromedriver"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver"] }
 
 # With automatic WebDriver download
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_chromedriver", "static_export_downloader"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
 
 # Recommended: Default configuration with Firefox + auto-download
 [dependencies]
-plotly = { version = "0.12", features = ["static_export_default"] }
+plotly = { version = "0.13", features = ["static_export_default"] }
 ```
 
 ## Prerequisites

examples/static_export/README.md

@@ -24,20 +24,20 @@ The `plotly_static` crate provides a high-level interface for converting Plotly
 
 The example uses `static_export_default` which includes:
 - `plotly_static`: Core static export functionality
-- `plotly_static/geckodriver`: Firefox WebDriver support
+- `plotly_static/chromedriver`: Chrome WebDriver support
 - `plotly_static/webdriver_download`: Automatic WebDriver download
 
 ### Alternative Configurations
 
 ```toml
 # Use Chrome/Chromium instead of Firefox
-plotly = { version = "0.12", features = ["static_export_chromedriver", "static_export_downloader"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
 
 # Manual WebDriver installation (no automatic download)
-plotly = { version = "0.12", features = ["static_export_geckodriver"] }
+plotly = { version = "0.13", features = ["static_export_geckodriver"] }
 
 # Chrome with manual installation
-plotly = { version = "0.12", features = ["static_export_chromedriver"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver"] }
 ```
 
 ## Running the Example

examples/static_export/src/main.rs

@@ -1,4 +1,3 @@
-use env_logger;
 use log::info;
 use plotly::plotly_static::{ImageFormat, StaticExporterBuilder};
 use plotly::{Plot, Scatter};
@@ -41,7 +40,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     // Demonstrate string-based export (useful for web applications)
     info!("Exporting to base64 and SVG strings...");
-    
+
     // Get base64 data (useful for embedding in HTML or APIs)
     let base64_data =
         plot1.to_base64_with_exporter(&mut exporter, ImageFormat::PNG, 400, 300, 1.0)?;

plotly/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "plotly"
-version = "0.12.1"
+version = "0.13.0"
 description = "A plotting library powered by Plotly.js"
 authors = ["Ioannis Giagkiozis <[email protected]>", "Andrei Gherghescu <[email protected]>"]
 license = "MIT"
@@ -22,7 +22,10 @@ kaleido_download = ["plotly_kaleido/download"]
 static_export_downloader = ["plotly_static/webdriver_download"]
 static_export_chromedriver = ["plotly_static", "plotly_static/chromedriver"]
 static_export_geckodriver = ["plotly_static", "plotly_static/geckodriver"]
-static_export_default = ["plotly_static", "plotly_static/geckodriver", "plotly_static/webdriver_download"]
+static_export_default = ["plotly_static", "plotly_static/chromedriver", "plotly_static/webdriver_download"]
+
+# All non-conflicting features
+all = ["plotly_ndarray", "plotly_image", "plotly_embed_js", "static_export_default"]
 
 plotly_ndarray = ["ndarray"]
 plotly_image = ["image"]
@@ -33,7 +36,7 @@ askama = { version = "0.14.0", features = ["serde_json"] }
 dyn-clone = "1"
 erased-serde = "0.4"
 image = { version = "0.25", optional = true }
-plotly_derive = { version = "0.12", path = "../plotly_derive" }
+plotly_derive = { version = "0.13", path = "../plotly_derive" }
 plotly_static = { version = "0.0.1", path = "../plotly_static", optional = true }
 plotly_kaleido = { version = "0.12", path = "../plotly_kaleido", optional = true }
 ndarray = { version = "0.16", optional = true }

plotly/src/layout/mod.rs

@@ -65,19 +65,19 @@ impl std::fmt::Display for ControlBuilderError {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             ControlBuilderError::RestyleSerializationError(e) => {
-                write!(f, "Failed to serialize restyle: {}", e)
+                write!(f, "Failed to serialize restyle: {e}")
             }
             ControlBuilderError::RelayoutSerializationError(e) => {
-                write!(f, "Failed to serialize relayout: {}", e)
+                write!(f, "Failed to serialize relayout: {e}")
             }
             ControlBuilderError::ValueSerializationError(e) => {
-                write!(f, "Failed to serialize value: {}", e)
+                write!(f, "Failed to serialize value: {e}")
             }
             ControlBuilderError::InvalidRestyleObject(s) => {
-                write!(f, "Invalid restyle object: expected object but got {}", s)
+                write!(f, "Invalid restyle object: expected object but got {s}")
             }
             ControlBuilderError::InvalidRelayoutObject(s) => {
-                write!(f, "Invalid relayout object: expected object but got {}", s)
+                write!(f, "Invalid relayout object: expected object but got {s}")
             }
         }
     }

plotly/src/plot.rs

@@ -233,7 +233,7 @@ impl Plot {
         let mut temp = env::temp_dir();
         let mut plot_name = Alphanumeric.sample_string(&mut rng(), 22);
         plot_name.push_str(".html");
-        plot_name = format!("plotly_{}", plot_name);
+        plot_name = format!("plotly_{plot_name}");
         temp.push(plot_name);
 
         // Save the rendered plot to the temp file.
@@ -276,7 +276,7 @@ impl Plot {
         let mut temp = env::temp_dir();
         let mut plot_name = Alphanumeric.sample_string(&mut rng(), 22);
         plot_name.push_str(".html");
-        plot_name = format!("plotly_{}", plot_name);
+        plot_name = format!("plotly_{plot_name}");
         temp.push(plot_name);
 
         // Save the rendered plot to the temp file.
@@ -350,18 +350,14 @@ impl Plot {
     /// Display plot in Jupyter Notebook.
     pub fn notebook_display(&self) {
         let plot_data = self.to_jupyter_notebook_html();
-        println!(
-            "EVCXR_BEGIN_CONTENT text/html\n{}\nEVCXR_END_CONTENT",
-            plot_data
-        );
+        println!("EVCXR_BEGIN_CONTENT text/html\n{plot_data}\nEVCXR_END_CONTENT");
     }
 
     /// Display plot in Jupyter Lab.
     pub fn lab_display(&self) {
         let plot_data = self.to_json();
         println!(
-            "EVCXR_BEGIN_CONTENT application/vnd.plotly.v1+json\n{}\nEVCXR_END_CONTENT",
-            plot_data
+            "EVCXR_BEGIN_CONTENT application/vnd.plotly.v1+json\n{plot_data}\nEVCXR_END_CONTENT"
         );
     }
 
@@ -487,7 +483,7 @@ impl Plot {
     ) -> Result<(), Box<dyn std::error::Error>> {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .build()
-            .map_err(|e| format!("Failed to create StaticExporter: {}", e))?;
+            .map_err(|e| format!("Failed to create StaticExporter: {e}"))?;
         self.write_image_with_exporter(&mut exporter, filename, format, width, height, scale)
     }
 
@@ -515,7 +511,7 @@ impl Plot {
     ) -> Result<String, Box<dyn std::error::Error>> {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .build()
-            .map_err(|e| format!("Failed to create StaticExporter: {}", e))?;
+            .map_err(|e| format!("Failed to create StaticExporter: {e}"))?;
         self.to_base64_with_exporter(&mut exporter, format, width, height, scale)
     }
 
@@ -538,7 +534,7 @@ impl Plot {
     ) -> Result<String, Box<dyn std::error::Error>> {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .build()
-            .map_err(|e| format!("Failed to create StaticExporter: {}", e))?;
+            .map_err(|e| format!("Failed to create StaticExporter: {e}"))?;
         self.to_svg_with_exporter(&mut exporter, width, height, scale)
     }
 
@@ -752,9 +748,8 @@ impl Plot {
         let local_plotly_js = include_str!("../resource/plotly.min.js");
 
         format!(
-            "<script type=\"text/javascript\">{}</script>\n
-            <script type=\"text/javascript\">{}</script>\n",
-            local_plotly_js, local_tex_svg_js,
+            "<script type=\"text/javascript\">{local_plotly_js}</script>\n
+            <script type=\"text/javascript\">{local_tex_svg_js}</script>\n",
         )
         .to_string()
     }

plotly_derive/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "plotly_derive"
-version = "0.12.1"
+version = "0.13.0"
 description = "Internal proc macro crate for Plotly-rs."
 authors = ["Ioannis Giagkiozis <[email protected]>"]
 license = "MIT"