try ubuntu + firefox without CI env vars

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

.github/workflows/ci.yml

@@ -79,7 +79,7 @@ jobs:
             features: plotly_ndarray,plotly_image,static_export_default,ci
           - os: ubuntu-latest
             browser: firefox
-            features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_downloader,ci
+            features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_wd_download,ci
           - os: windows-latest
             browser: chrome
             features: plotly_ndarray,plotly_image,static_export_chromedriver,ci
@@ -132,7 +132,7 @@ jobs:
       # Run tests on Ubuntu with Chrome
       - name: Run tests (${{ matrix.os }} - Chrome)
         if: matrix.os == 'ubuntu-latest' && matrix.browser == 'chrome'
-        run: cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+        run: cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
 
       # Install xvfb for Firefox WebGL support
       - name: Install xvfb
@@ -144,12 +144,6 @@ jobs:
       # Run tests on Ubuntu with Firefox
       - name: Run tests (${{ matrix.os }} - Firefox)
         if: matrix.os == 'ubuntu-latest' && matrix.browser == 'firefox'
-        env:
-          MOZ_HEADLESS: 1
-          LIBGL_ALWAYS_SOFTWARE: 1
-          MESA_GL_VERSION_OVERRIDE: 3.3
-          MOZ_DISABLE_RDD_SANDBOX: 1
-          MOZ_DISABLE_CONTENT_SANDBOX: 1
         run: |
           # Set environment variables for Firefox WebDriver
           export BROWSER_PATH="${{ steps.setup-firefox.outputs.firefox-path }}"
@@ -160,12 +154,12 @@ jobs:
           echo "BROWSER_PATH: $BROWSER_PATH"
           echo "RUST_LOG: $RUST_LOG"
           
-          xvfb-run -s "-screen 0 1920x1080x24" cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+          xvfb-run -s "-screen 0 1920x1080x24" cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
 
       # Run tests on macOS with Chrome
       - name: Run tests (${{ matrix.os }} - Chrome)
         if: matrix.os == 'macos-latest' && matrix.browser == 'chrome'
-        run: cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+        run: cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
 
       # Run tests on Windows with Chrome WebDriver
       - name: Run tests (${{ matrix.os }} - Chrome)
@@ -183,13 +177,13 @@ jobs:
           Write-Host "WEBDRIVER_PATH: $env:WEBDRIVER_PATH"
           Write-Host "BROWSER_PATH: $env:BROWSER_PATH"
 
-          cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido          
+          cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido          
 
       - name: Upload example.pdf artifact
         uses: actions/upload-artifact@v4
         with:
-          name: example-pdf-${{ matrix.os }}
-          path: ${{ github.workspace }}/plotly_static/example.pdf
+          name: example-pdf-${{ matrix.os }}-${{ matrix.browser }}
+          path: ${{ github.workspace }}/plotly_static/example.*
           retention-days: 30
 
   code-coverage:

docs/book/src/fundamentals/static_image_export.md

@@ -15,7 +15,7 @@ The static export functionality is controlled by feature flags in the main `plot
 - `static_export_geckodriver`: Uses Firefox for rendering (requires geckodriver)
 
 ### Optional Features:
-- `static_export_downloader`: Automatically downloads WebDriver binaries at build time
+- `static_export_wd_download`: Automatically downloads WebDriver binaries at build time
 - `static_export_default`: Convenience feature that includes chromedriver + downloader
 
 ### Cargo.toml Configuration Examples:
@@ -27,7 +27,7 @@ plotly = { version = "0.13", features = ["static_export_chromedriver"] }
 
 # With automatic WebDriver download
 [dependencies]
-plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_wd_download"] }
 
 # Recommended: Default configuration with Firefox + auto-download
 [dependencies]
@@ -39,7 +39,7 @@ plotly = { version = "0.13", features = ["static_export_default"] }
 1. **WebDriver Installation**: You need either chromedriver or geckodriver installed
    - Chrome: Download from https://chromedriver.chromium.org/
    - Firefox: Download from https://github.com/mozilla/geckodriver/releases
-   - Or use the `static_export_downloader` feature for automatic download
+   - Or use the `static_export_wd_download` feature for automatic download
 
 2. **Browser Installation**: You need Chrome/Chromium or Firefox installed
 

examples/static_export/README.md

@@ -31,7 +31,7 @@ The example uses `static_export_default` which includes:
 
 ```toml
 # Use Chrome/Chromium instead of Firefox
-plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
+plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_wd_download"] }
 
 # Manual WebDriver installation (no automatic download)
 plotly = { version = "0.13", features = ["static_export_geckodriver"] }

plotly/Cargo.toml

@@ -19,9 +19,9 @@ kaleido = ["plotly_kaleido"]
 # DEPRECATED: kaleido_download feature will be removed in version 0.14.0. Use plotly_static_download instead.
 kaleido_download = ["plotly_kaleido/download"]
 
-static_export_downloader = ["plotly_static/webdriver_download"]
 static_export_chromedriver = ["plotly_static", "plotly_static/chromedriver"]
 static_export_geckodriver = ["plotly_static", "plotly_static/geckodriver"]
+static_export_wd_download = ["plotly_static/webdriver_download"]
 static_export_default = ["plotly_static", "plotly_static/chromedriver", "plotly_static/webdriver_download"]
 
 # All non-conflicting features

plotly_static/src/lib.rs

@@ -1025,19 +1025,23 @@ impl StaticExporter {
         // Don't close the client - keep it for reuse
         // client.close().await?;
 
-        let src = data.as_str().ok_or(anyhow!(
+        let result = data.as_str().ok_or(anyhow!(
             "Failed to execute Plotly.toImage in browser session"
         ))?;
 
+        if let Some(err) = result.strip_prefix("ERROR:") {
+            return Err(anyhow!("JavaScript error during export: {err}"));
+        }
+
         match plot.format {
-            ImageFormat::SVG => Self::extract_plain(src, &plot.format),
+            ImageFormat::SVG => Self::extract_plain(result, &plot.format),
             ImageFormat::PNG | ImageFormat::JPEG | ImageFormat::WEBP | ImageFormat::PDF => {
-                Self::extract_encoded(src, &plot.format)
+                Self::extract_encoded(result, &plot.format)
             }
             #[allow(deprecated)]
             ImageFormat::EPS => {
                 error!("EPS format is deprecated. Use SVG or PDF instead.");
-                Self::extract_encoded(src, &plot.format)
+                Self::extract_encoded(result, &plot.format)
             }
         }
     }