more robust pdf generation on windows and adding a debug feature flag

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

.github/workflows/ci.yml

@@ -76,16 +76,16 @@ jobs:
         include:
           - os: ubuntu-latest
             browser: chrome
-            features: plotly_ndarray,plotly_image,static_export_default,ci
+            features: plotly_ndarray,plotly_image,static_export_default,debug
           - os: ubuntu-latest
             browser: firefox
-            features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_wd_download,ci
+            features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_wd_download,debug
           - os: windows-latest
             browser: chrome
-            features: plotly_ndarray,plotly_image,static_export_chromedriver,ci
+            features: plotly_ndarray,plotly_image,static_export_chromedriver,debug
           - os: macos-latest
             browser: chrome
-            features: plotly_ndarray,plotly_image,static_export_default,ci
+            features: plotly_ndarray,plotly_image,static_export_default,debug
     runs-on: ${{ matrix.os }}
     timeout-minutes: ${{ matrix.os == 'windows-latest' && 30 || 10 }}
     steps:
@@ -183,7 +183,10 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: example-pdf-${{ matrix.os }}-${{ matrix.browser }}
-          path: ${{ github.workspace }}/plotly_static/example.*
+          path: |
+            ${{ github.workspace }}/plotly_static/static_example.*
+            ${{ github.workspace }}/plotly/plotly_example.*
+            ${{ github.workspace }}/plotly/plotly_example_surface.*
           retention-days: 30
 
   code-coverage:

examples/static_export/src/main.rs

@@ -4,8 +4,8 @@ use plotly::{Plot, Scatter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Initialize logging for debugging and monitoring
-    // Set RUST_LOG=debug to see detailed WebDriver operations
-    env_logger::init();
+    // Set log level to info by default
+    env_logger::Builder::from_env(env_logger::Env::default().default_filter_or("info")).init();
 
     info!("Starting static export example...");
     info!("This example demonstrates efficient exporter reuse and multiple formats");

plotly/Cargo.toml

@@ -26,6 +26,8 @@ static_export_default = ["plotly_static", "plotly_static/chromedriver", "plotly_
 
 # All non-conflicting features
 all = ["plotly_ndarray", "plotly_image", "plotly_embed_js", "static_export_default"]
+# This is used for enabling extra debugging messages and debugging functionality
+debug = ["plotly_static?/debug"]
 
 plotly_ndarray = ["ndarray"]
 plotly_image = ["image"]

plotly/src/plot.rs

@@ -997,11 +997,11 @@ mod tests {
     #[test]
     fn save_html() {
         let plot = create_test_plot();
-        let dst = PathBuf::from("example.html");
+        let dst = PathBuf::from("plotly_example.html");
         plot.write_html(&dst);
         assert!(dst.exists());
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 
     #[cfg(feature = "plotly_static")]
@@ -1017,7 +1017,7 @@ mod tests {
     #[cfg(feature = "plotly_static")]
     fn save_to_png() {
         let plot = create_test_plot();
-        let dst = PathBuf::from("example.png");
+        let dst = PathBuf::from("plotly_example.png");
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .webdriver_port(get_unique_port())
             .build()
@@ -1028,15 +1028,15 @@ mod tests {
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 0,);
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 
     #[test]
     #[cfg(feature = "plotly_static")]
     fn save_to_jpeg() {
         let plot = create_test_plot();
-        let dst = PathBuf::from("example.jpeg");
+        let dst = PathBuf::from("plotly_example.jpeg");
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .webdriver_port(get_unique_port())
             .build()
@@ -1047,15 +1047,15 @@ mod tests {
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 0,);
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 
     #[test]
     #[cfg(feature = "plotly_static")]
     fn save_to_svg() {
         let plot = create_test_plot();
-        let dst = PathBuf::from("example.svg");
+        let dst = PathBuf::from("plotly_example.svg");
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .webdriver_port(get_unique_port())
             .build()
@@ -1066,35 +1066,42 @@ mod tests {
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 0,);
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 
     #[test]
     #[cfg(feature = "plotly_static")]
     fn save_to_pdf() {
         let plot = create_test_plot();
-        let dst = PathBuf::from("example.pdf");
+        let dst = PathBuf::from("plotly_example.pdf");
+        #[cfg(feature = "debug")]
         let mut exporter = plotly_static::StaticExporterBuilder::default()
+            .spawn_webdriver(true)
             .webdriver_port(get_unique_port())
             .pdf_export_timeout(750)
             .build()
             .unwrap();
+        #[cfg(not(feature = "debug"))]
+        let mut exporter = plotly_static::StaticExporterBuilder::default()
+            .webdriver_port(get_unique_port())
+            .build()
+            .unwrap();
         plot.write_image_with_exporter(&mut exporter, &dst, ImageFormat::PDF, 1024, 680, 1.0)
             .unwrap();
         assert!(dst.exists());
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 0,);
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 
     #[test]
     #[cfg(feature = "plotly_static")]
     fn save_to_webp() {
         let plot = create_test_plot();
-        let dst = PathBuf::from("example.webp");
+        let dst = PathBuf::from("plotly_example.webp");
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .webdriver_port(get_unique_port())
             .build()
@@ -1105,8 +1112,8 @@ mod tests {
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 0,);
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 
     #[test]
@@ -1173,7 +1180,7 @@ mod tests {
             .name("Surface");
 
         plot.add_trace(surface);
-        let dst = PathBuf::from("example.png");
+        let dst = PathBuf::from("plotly_example_surface.png");
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .webdriver_port(get_unique_port())
             .build()
@@ -1191,7 +1198,7 @@ mod tests {
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 0,);
+        #[cfg(not(feature = "debug"))]
         assert!(std::fs::remove_file(&dst).is_ok());
-        assert!(!dst.exists());
     }
 }

plotly_static/Cargo.toml

@@ -16,8 +16,8 @@ exclude = ["target/*"]
 webdriver_download = []
 geckodriver = []
 chromedriver = []
-# This is used for CI testing
-ci = []
+# This is used for enabling extra debugging messages and debugging functionality
+debug = []
 
 [dependencies]
 log = "0.4"