Skip to content

Commit b0f9e7a

Browse files
committed
try ubuntu + firefox without CI env vars
Signed-off-by: Andrei Gherghescu <[email protected]>
1 parent d68fe89 commit b0f9e7a

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
features: plotly_ndarray,plotly_image,static_export_default,ci
8080
- os: ubuntu-latest
8181
browser: firefox
82-
features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_downloader,ci
82+
features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_wd_download,ci
8383
- os: windows-latest
8484
browser: chrome
8585
features: plotly_ndarray,plotly_image,static_export_chromedriver,ci
@@ -144,12 +144,6 @@ jobs:
144144
# Run tests on Ubuntu with Firefox
145145
- name: Run tests (${{ matrix.os }} - Firefox)
146146
if: matrix.os == 'ubuntu-latest' && matrix.browser == 'firefox'
147-
env:
148-
MOZ_HEADLESS: 1
149-
LIBGL_ALWAYS_SOFTWARE: 1
150-
MESA_GL_VERSION_OVERRIDE: 3.3
151-
MOZ_DISABLE_RDD_SANDBOX: 1
152-
MOZ_DISABLE_CONTENT_SANDBOX: 1
153147
run: |
154148
# Set environment variables for Firefox WebDriver
155149
export BROWSER_PATH="${{ steps.setup-firefox.outputs.firefox-path }}"
@@ -188,7 +182,7 @@ jobs:
188182
- name: Upload example.pdf artifact
189183
uses: actions/upload-artifact@v4
190184
with:
191-
name: example-pdf-${{ matrix.os }}
185+
name: example-pdf-${{ matrix.os }}-${{ matrix.browser }}
192186
path: ${{ github.workspace }}/plotly_static/example.pdf
193187
retention-days: 30
194188

docs/book/src/fundamentals/static_image_export.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ The static export functionality is controlled by feature flags in the main `plot
1515
- `static_export_geckodriver`: Uses Firefox for rendering (requires geckodriver)
1616

1717
### Optional Features:
18-
- `static_export_downloader`: Automatically downloads WebDriver binaries at build time
18+
- `static_export_wd_download`: Automatically downloads WebDriver binaries at build time
1919
- `static_export_default`: Convenience feature that includes chromedriver + downloader
2020

2121
### Cargo.toml Configuration Examples:
@@ -27,7 +27,7 @@ plotly = { version = "0.13", features = ["static_export_chromedriver"] }
2727

2828
# With automatic WebDriver download
2929
[dependencies]
30-
plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
30+
plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_wd_download"] }
3131

3232
# Recommended: Default configuration with Firefox + auto-download
3333
[dependencies]
@@ -39,7 +39,7 @@ plotly = { version = "0.13", features = ["static_export_default"] }
3939
1. **WebDriver Installation**: You need either chromedriver or geckodriver installed
4040
- Chrome: Download from https://chromedriver.chromium.org/
4141
- Firefox: Download from https://github.com/mozilla/geckodriver/releases
42-
- Or use the `static_export_downloader` feature for automatic download
42+
- Or use the `static_export_wd_download` feature for automatic download
4343

4444
2. **Browser Installation**: You need Chrome/Chromium or Firefox installed
4545

examples/static_export/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ The example uses `static_export_default` which includes:
3131

3232
```toml
3333
# Use Chrome/Chromium instead of Firefox
34-
plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_downloader"] }
34+
plotly = { version = "0.13", features = ["static_export_chromedriver", "static_export_wd_download"] }
3535

3636
# Manual WebDriver installation (no automatic download)
3737
plotly = { version = "0.13", features = ["static_export_geckodriver"] }

plotly/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ kaleido = ["plotly_kaleido"]
1919
# DEPRECATED: kaleido_download feature will be removed in version 0.14.0. Use plotly_static_download instead.
2020
kaleido_download = ["plotly_kaleido/download"]
2121

22-
static_export_downloader = ["plotly_static/webdriver_download"]
2322
static_export_chromedriver = ["plotly_static", "plotly_static/chromedriver"]
2423
static_export_geckodriver = ["plotly_static", "plotly_static/geckodriver"]
24+
static_export_wd_download = ["plotly_static/webdriver_download"]
2525
static_export_default = ["plotly_static", "plotly_static/chromedriver", "plotly_static/webdriver_download"]
2626

2727
# All non-conflicting features

0 commit comments

Comments
 (0)