add ubuntu firefox job to test matrix

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

.github/workflows/ci.yml

@@ -70,17 +70,37 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        include:
+          - os: ubuntu-latest
+            browser: chrome
+            features: plotly_ndarray,plotly_image,static_export_default
+          - os: ubuntu-latest
+            browser: firefox
+            features: plotly_ndarray,plotly_image,static_export_geckodriver,static_export_downloader
+          - os: windows-latest
+            browser: chrome
+            features: plotly_ndarray,plotly_image,static_export_chromedriver
+          - os: macos-latest
+            browser: chrome
+            features: plotly_ndarray,plotly_image,static_export_default
     runs-on: ${{ matrix.os }}
     timeout-minutes: ${{ matrix.os == 'windows-latest' && 30 || 10 }}
     steps:
       - name: Setup Chrome
+        if: matrix.browser == 'chrome'
         uses: browser-actions/setup-chrome@v1
         with:
           chrome-version: 'latest'
           install-chromedriver: true
         id: setup-chrome
 
+      - name: Setup Firefox
+        if: matrix.browser == 'firefox'
+        uses: browser-actions/setup-firefox@v1
+        with:
+          firefox-version: 'latest'
+        id: setup-firefox
+
       - uses: actions/checkout@v4
 
       - uses: dtolnay/rust-toolchain@stable
@@ -106,14 +126,50 @@ jobs:
             -ChromePath "${{ steps.setup-chrome.outputs.chrome-path }}" `
             -ChromeDriverPath "${{ steps.setup-chrome.outputs.chromedriver-path }}"
 
-      # Run tests on non-Windows platforms
-      - name: Run tests (${{ matrix.os }})
-        if: matrix.os != 'windows-latest'
-        run: cargo test --verbose --workspace --features plotly_ndarray,plotly_image,static_export_default --exclude plotly_kaleido
+      # Run tests on Ubuntu with Chrome
+      - name: Run tests (${{ matrix.os }} - Chrome)
+        if: matrix.os == 'ubuntu-latest' && matrix.browser == 'chrome'
+        run: cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+
+      # Run save_surface_to_png test with nocapture for detailed webdriver logs
+      - name: Run save_surface_to_png test with nocapture (${{ matrix.os }} - Firefox)
+        if: matrix.os == 'ubuntu-latest' && matrix.browser == 'firefox'
+        run: |
+          # Set environment variables for Firefox WebDriver
+          export BROWSER_PATH="${{ steps.setup-firefox.outputs.firefox-path }}"
+          export RUST_LOG="debug"
+          export RUST_BACKTRACE="1"
+          
+          echo "Environment variables set:"
+          echo "BROWSER_PATH: $BROWSER_PATH"
+          echo "RUST_LOG: $RUST_LOG"
+          
+          # Run only the save_surface_to_png test with nocapture for full webdriver logs
+          cargo test save_surface_to_png --verbose --features ${{ matrix.features }} -- --nocapture
+
+      # Run tests on Ubuntu with Firefox
+      - name: Run tests (${{ matrix.os }} - Firefox)
+        if: matrix.os == 'ubuntu-latest' && matrix.browser == 'firefox'
+        run: |
+          # Set environment variables for Firefox WebDriver
+          export BROWSER_PATH="${{ steps.setup-firefox.outputs.firefox-path }}"
+          export RUST_LOG="debug"
+          export RUST_BACKTRACE="1"
+          
+          echo "Environment variables set:"
+          echo "BROWSER_PATH: $BROWSER_PATH"
+          echo "RUST_LOG: $RUST_LOG"
+          
+          cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+
+      # Run tests on macOS with Chrome
+      - name: Run tests (${{ matrix.os }} - Chrome)
+        if: matrix.os == 'macos-latest' && matrix.browser == 'chrome'
+        run: cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
 
       # Run tests on Windows with Chrome WebDriver
-      - name: Run tests (${{ matrix.os }})
-        if: matrix.os == 'windows-latest'
+      - name: Run tests (${{ matrix.os }} - Chrome)
+        if: matrix.os == 'windows-latest' && matrix.browser == 'chrome'
         shell: pwsh
         run: |
           # Set environment variables for WebDriver
@@ -127,7 +183,7 @@ jobs:
           Write-Host "WEBDRIVER_PATH: $env:WEBDRIVER_PATH"
           Write-Host "BROWSER_PATH: $env:BROWSER_PATH"
 
-          cargo test --verbose --workspace --features plotly_ndarray,plotly_image,static_export_chromedriver --exclude plotly_kaleido
+          cargo test --verbose --workspace --features ${{ matrix.features }} --exclude plotly_kaleido          
 
       - name: Upload example.pdf artifact
         uses: actions/upload-artifact@v4

plotly_static/src/lib.rs

@@ -108,7 +108,7 @@
 //! export BROWSER_PATH="/path/to/chrome"
 //!
 //! # For Firefox
-//! export FIREFOX_PATH="/path/to/firefox"
+//! export BROWSER_PATH="/path/to/firefox"
 //! ```
 //!
 //! The library will automatically use these binaries when creating WebDriver
@@ -1092,9 +1092,9 @@ impl StaticExporter {
             browser_opts.insert("binary".to_string(), serde_json::json!(chrome_path));
             debug!("Added Chrome binary capability: {chrome_path}");
         }
-        // Add Firefox binary capability if FIREFOX_PATH is set
+        // Add Firefox binary capability if BROWSER_PATH is set
         #[cfg(feature = "geckodriver")]
-        if let Ok(firefox_path) = std::env::var("FIREFOX_PATH") {
+        if let Ok(firefox_path) = std::env::var("BROWSER_PATH") {
             browser_opts.insert("binary".to_string(), serde_json::json!(firefox_path));
             debug!("Added Firefox binary capability: {}", firefox_path);
         }