try offline mode in the ci for pdf

Signed-off-by: Andrei Gherghescu <[email protected]>

Author: andrei-ng

plotly/src/plot.rs

@@ -1078,6 +1078,7 @@ mod tests {
         let mut exporter = plotly_static::StaticExporterBuilder::default()
             .webdriver_port(get_unique_port())
             .pdf_export_timeout(750)
+            .offline_mode(true)
             .build()
             .unwrap();
         plot.write_image_with_exporter(&mut exporter, &dst, ImageFormat::PDF, 1024, 680, 1.0)

plotly_static/src/lib.rs

@@ -278,71 +278,6 @@ use webdriver::WebDriver;
 
 use crate::template::{image_export_js_script, pdf_export_js_script};
 
-#[cfg(all(feature = "chromedriver", not(target_os = "windows")))]
-fn chrome_default_caps() -> Vec<&'static str> {
-    vec![
-        "--headless",
-        "--no-sandbox",
-        "--disable-gpu-sandbox",
-        "--disable-dev-shm-usage",
-        "--disable-extensions",
-        "--disable-background-networking",
-        "--disable-sync",
-        "--disable-translate",
-        "--disable-background-timer-throttling",
-        "--disable-renderer-backgrounding",
-        "--disable-features=VizDisplayCompositor",
-        "--memory-pressure-off",
-        // macOS-specific flags from choreographer
-        "--enable-unsafe-swiftshader",
-        "--use-mock-keychain",
-        "--password-store=basic",
-        "--disable-web-security",
-        "--disable-breakpad",
-        "--no-first-run",
-        "--no-default-browser-check",
-        // Additional flags for better PDF generation support
-        "--disable-backgrounding-occluded-windows",
-        "--disable-ipc-flooding-protection",
-        "--enable-logging",
-        "--v=1",
-    ]
-}
-
-#[cfg(all(feature = "chromedriver", target_os = "windows"))]
-fn chrome_default_caps() -> Vec<&'static str> {
-    vec![
-        "--headless=new",
-        "--no-sandbox",
-        "--disable-dev-shm-usage",
-        "--disable-breakpad",
-        "--no-first-run",
-        "--no-default-browser-check",
-        // Stability flags to prevent renderer crashes
-        "--disable-background-networking",
-        "--disable-sync",
-        "--disable-translate",
-        "--disable-background-timer-throttling",
-        "--disable-renderer-backgrounding",
-        "--disable-backgrounding-occluded-windows",
-        "--disable-ipc-flooding-protection",
-        "--disable-extensions",
-        // Minimal flags for Windows headless operation without disabling GPU
-        "--hide-scrollbars",
-        "--mute-audio",
-        "--use-angle=swiftshader",
-        "--disable-software-rasterizer",
-    ]
-}
-
-#[cfg(feature = "geckodriver")]
-fn firefox_default_caps() -> Vec<&'static str> {
-    vec![
-        "-headless",   // Essential for headless operation (single dash for Firefox)
-        "--no-remote", // Prevents connecting to existing Firefox instances
-    ]
-}
-
 mod template;
 mod webdriver;
 
@@ -506,14 +441,14 @@ impl Default for StaticExporterBuilder {
             webdriver_browser_caps: {
                 #[cfg(feature = "chromedriver")]
                 {
-                    chrome_default_caps()
+                    crate::webdriver::chrome_default_caps()
                         .into_iter()
                         .map(|s| s.to_string())
                         .collect()
                 }
                 #[cfg(feature = "geckodriver")]
                 {
-                    firefox_default_caps()
+                    crate::webdriver::firefox_default_caps()
                         .into_iter()
                         .map(|s| s.to_string())
                         .collect()
@@ -1398,6 +1333,7 @@ mod tests {
             .spawn_webdriver(true)
             .webdriver_port(get_unique_port())
             .pdf_export_timeout(750)
+            .offline_mode(true)
             .build()
             .unwrap();
 
@@ -1416,8 +1352,8 @@ mod tests {
         let metadata = std::fs::metadata(&dst).expect("Could not retrieve file metadata");
         let file_size = metadata.len();
         assert!(file_size > 600000,);
-        #[cfg(not(feature = "ci"))]
-        assert!(std::fs::remove_file(dst.as_path()).is_ok());
+        // #[cfg(not(feature = "ci"))]
+        // assert!(std::fs::remove_file(dst.as_path()).is_ok());
     }
 
     #[test]

plotly_static/src/webdriver.rs

@@ -34,6 +34,74 @@ pub(crate) const WEBDRIVER_PORT: u32 = 4444;
 /// Default WebDriver URL
 pub(crate) const WEBDRIVER_URL: &str = "http://localhost";
 
+#[cfg(all(feature = "chromedriver", not(target_os = "windows")))]
+pub(crate) fn chrome_default_caps() -> Vec<&'static str> {
+    vec![
+        "--headless",
+        "--no-sandbox",
+        "--disable-gpu-sandbox",
+        "--disable-dev-shm-usage",
+        "--disable-extensions",
+        "--disable-background-networking",
+        "--disable-sync",
+        "--disable-translate",
+        "--disable-background-timer-throttling",
+        "--disable-renderer-backgrounding",
+        "--disable-features=VizDisplayCompositor",
+        "--memory-pressure-off",
+        // macOS-specific flags from choreographer
+        "--enable-unsafe-swiftshader",
+        "--use-mock-keychain",
+        "--password-store=basic",
+        "--disable-web-security",
+        "--allow-file-access-from-files",
+        "--disable-breakpad",
+        "--no-first-run",
+        "--no-default-browser-check",
+        // Additional flags for better PDF generation support
+        "--disable-backgrounding-occluded-windows",
+        "--disable-ipc-flooding-protection",
+        "--enable-logging",
+        "--v=1",
+    ]
+}
+
+#[cfg(all(feature = "chromedriver", target_os = "windows"))]
+pub(crate) fn chrome_default_caps() -> Vec<&'static str> {
+    vec![
+        "--headless=new",
+        "--no-sandbox",
+        "--disable-dev-shm-usage",
+        "--disable-breakpad",
+        "--no-first-run",
+        "--no-default-browser-check",
+        // Stability flags to prevent renderer crashes
+        "--disable-background-networking",
+        "--disable-sync",
+        "--disable-translate",
+        "--disable-background-timer-throttling",
+        "--disable-renderer-backgrounding",
+        "--disable-backgrounding-occluded-windows",
+        "--disable-ipc-flooding-protection",
+        "--disable-extensions",
+        "--disable-web-security",
+        "--allow-file-access-from-files",
+        // Minimal flags for Windows headless operation without disabling GPU
+        "--hide-scrollbars",
+        "--mute-audio",
+        "--use-angle=swiftshader",
+        "--disable-software-rasterizer",
+    ]
+}
+
+#[cfg(feature = "geckodriver")]
+pub(crate) fn firefox_default_caps() -> Vec<&'static str> {
+    vec![
+        "-headless",   // Essential for headless operation (single dash for Firefox)
+        "--no-remote", // Prevents connecting to existing Firefox instances
+    ]
+}
+
 /// Internal WebDriver state
 #[derive(Debug)]
 struct WdInner {