Fixed mousepad dragging

Author: timothyschoen

Source/Box.cpp

@@ -73,7 +73,6 @@ void Box::changeListenerCallback(ChangeBroadcaster* source)
     // If the object has graphics, we hide the draggable name object
     if (graphics && !graphics->fakeGui() && (locked || cnv->isGraph))
     {
-        // textLabel.setVisible(false);
         resizer.setVisible(false);
     }
     else
@@ -382,6 +381,7 @@ void Box::updatePorts()
 
         edge->edgeIdx = input ? numIn : numOut;
         edge->isSignal = isSignal;
+        edge->setAlwaysOnTop(true);
 
         numIn += input;
         numOut += !input;

Source/Connection.cpp

@@ -215,6 +215,9 @@ void Connection::mouseMove(const MouseEvent& e)
 
 void Connection::mouseDown(const MouseEvent& e)
 {
+    
+    if(currentPlan.empty()) return;
+    
     const auto scaledPlan = scalePath(currentPlan);
 
     if (scaledPlan.size() <= 2) return;
@@ -254,6 +257,8 @@ void Connection::mouseDown(const MouseEvent& e)
 
 void Connection::mouseDrag(const MouseEvent& e)
 {
+    if(currentPlan.empty()) return;
+    
     auto& first = start->isInput ? start : end;
     auto& last = start->isInput ? end : start;
 

Source/GUIObjects.cpp

@@ -1009,7 +1009,6 @@ GraphOnParent::GraphOnParent(const pd::Gui& pdGui, Box* box) : GUIComponent(pdGu
 GraphOnParent::~GraphOnParent()
 {
     box->textLabel.setVisible(true);
-    removeMouseListener(&box->textLabel);
     closeOpenedSubpatchers();
 }
 
@@ -1020,7 +1019,7 @@ void GraphOnParent::resized()
 void GraphOnParent::lock(bool locked)
 {
     isLocked = locked;
-    setInterceptsMouseClicks(!box->locked, true);
+    setInterceptsMouseClicks(isLocked, true);
 }
 
 void GraphOnParent::mouseDown(const MouseEvent& e)
@@ -1150,13 +1149,17 @@ void CommentComponent::paint(Graphics& g)
 MousePad::MousePad(const pd::Gui& gui, Box* box) : GUIComponent(gui, box)
 {
     Desktop::getInstance().addGlobalMouseListener(this);
-    // setInterceptsMouseClicks(false, true);
 
+    //setInterceptsMouseClicks(box->locked, box->locked);
+    
+    addMouseListener(&box->textLabel, false);
     box->textLabel.setVisible(false);
+    
 }
 
 MousePad::~MousePad()
 {
+    removeMouseListener(&box->textLabel);
     box->textLabel.setVisible(true);
     Desktop::getInstance().removeGlobalMouseListener(this);
 }