Merge pull request #1982 from kamomehettapi/fix/settings-menu-performance

improve menu opening performance

Author: timothyschoen

Source/Dialogs/ThemeSettingsPanel.h

@@ -545,9 +545,15 @@ class ThemeSettingsPanel : public SettingsDialogPanel
     void valueChanged(Value& v) override
     {
         if (v.refersToSameSourceAs(fontValue)) {
+            auto previousFontName = Fonts::getCurrentFont().toString();
+
             PlugDataLook::setDefaultFont(fontValue.toString());
             SettingsFile::getInstance()->setProperty("default_font", fontValue.getValue());
-            pd->updateAllEditorsLNF();
+
+            bool changed = previousFontName != Fonts::getCurrentFont().toString();
+            if (changed)
+                pd->updateAllEditorsLNF();
+
             return;
         }
 

Source/PluginProcessor.cpp

@@ -1296,6 +1296,9 @@ pd::Patch::Ptr PluginProcessor::loadPatch(String patchText)
 
 void PluginProcessor::setTheme(String themeToUse, bool force)
 {
+    if (themeToUse == currentThemeName)
+        return;
+
     auto oldThemeTree = settingsFile->getTheme(PlugDataLook::currentTheme);
     auto themeTree = settingsFile->getTheme(themeToUse);
     // Check if theme name is valid
@@ -1322,6 +1325,8 @@ void PluginProcessor::setTheme(String themeToUse, bool force)
     if ((propertyState == 1) || (propertyState == 0 ? static_cast<int>(previousIoletGeom) != static_cast<int>(currentIoletGeom) : 0)) {
         PluginEditor::updateIoletGeometryForAllObjects(this);
     }
+
+    currentThemeName = themeToUse;
 }
 
 void PluginProcessor::updateAllEditorsLNF()

Source/PluginProcessor.h

@@ -150,6 +150,7 @@ class PluginProcessor final : public AudioProcessor
 
     AtomicValue<float>* volume;
     ValueTree pluginModeTheme;
+    String currentThemeName;
 
     SettingsFile* settingsFile;