Fix MSVC compiler warnings

Author: timothyschoen

Source/Objects/IEMHelper.h

@@ -12,7 +12,7 @@ static int srl_is_valid(t_symbol const* s)
 }
 
 extern "C" {
-char* pdgui_strnescape(char* dst, size_t dstlen, char const* src, size_t srclen);
+EXTERN char* pdgui_strnescape(char* dst, size_t dstlen, char const* src, size_t srclen);
 }
 
 class IEMHelper {

Source/Pd/Instance.cpp

@@ -46,7 +46,7 @@ class ConsoleMessageHandler final : public Timer {
     {
         if (consoleMessages.size()) {
             auto& [lastObject, lastMessage, lastType, lastLength, numMessages] = consoleMessages.back();
-            if (object == lastObject && message == lastMessage && type == lastType) {
+            if (object == lastObject && message == lastMessage && static_cast<int>(type) == lastType) {
                 numMessages++;
             } else {
                 consoleMessages.emplace_back(object, message, type, CachedStringWidth<14>::calculateStringWidth(message) + 40, 1);
@@ -145,7 +145,7 @@ class ConsoleMessageHandler final : public Timer {
         }
     }
 
-    StackArray<char, 2048> printConcatBuffer;
+    StackArray<char, 2048> printConcatBuffer = {};
 
     moodycamel::ConcurrentQueue<std::tuple<void*, SmallString, bool>> pendingMessages = moodycamel::ConcurrentQueue<std::tuple<void*, SmallString, bool>>(512);
 };
@@ -156,7 +156,7 @@ struct Instance::dmessage {
         : object(ref, instance)
         , destination(dest)
         , selector(sel)
-        , list(std::move(atoms))
+        , list(atoms)
     {
     }
 

Source/Utility/Containers.h

@@ -37,6 +37,10 @@
 #    define GSL_OWNER
 #endif
 
+#ifndef __has_builtin
+#    define __has_builtin(x) 0
+#endif
+
 #if __has_builtin(__builtin_expect) || defined(__GNUC__)
 #    define EXPECT_LIKELY(EXPR) __builtin_expect((bool)(EXPR), true)
 #    define EXPECT_UNLIKELY(EXPR) __builtin_expect((bool)(EXPR), false)
@@ -45,10 +49,10 @@
 #    define EXPECT_UNLIKELY(EXPR) (EXPR)
 #endif
 
-#if __has_attribute(returns_nonnull)
-#    define ATTRIBUTE_RETURNS_NONNULL __attribute__((returns_nonnull))
-#elif defined(_MSC_VER)
+#if defined(_MSC_VER)
 #    define ATTRIBUTE_RETURNS_NONNULL _Ret_notnull_
+#elif __has_attribute(returns_nonnull)
+#    define ATTRIBUTE_RETURNS_NONNULL __attribute__((returns_nonnull))
 #else
 #    define LLVM_ATTRIBUTE_RETURNS_NONNULL
 #endif
@@ -1217,9 +1221,9 @@ class SmallArrayImpl : public SmallArrayTemplateBase<T> {
         return this->back();
     }
 
-    SmallArrayImpl& operator=(SmallArrayImpl const& RHS);
+    SmallArrayImpl& operator=(SmallArrayImpl const& RHS) noexcept;
 
-    SmallArrayImpl& operator=(SmallArrayImpl&& RHS);
+    SmallArrayImpl& operator=(SmallArrayImpl&& RHS) noexcept;
 
     bool operator==(SmallArrayImpl const& RHS) const
     {
@@ -1283,7 +1287,7 @@ void SmallArrayImpl<T>::swap(SmallArrayImpl<T>& RHS)
 
 template<typename T>
 SmallArrayImpl<T>& SmallArrayImpl<T>::
-operator=(SmallArrayImpl<T> const& RHS)
+operator=(SmallArrayImpl<T> const& RHS) noexcept
 {
     // Avoid self-assignment.
     if (this == &RHS)
@@ -1332,7 +1336,7 @@ operator=(SmallArrayImpl<T> const& RHS)
 }
 
 template<typename T>
-SmallArrayImpl<T>& SmallArrayImpl<T>::operator=(SmallArrayImpl<T>&& RHS)
+SmallArrayImpl<T>& SmallArrayImpl<T>::operator=(SmallArrayImpl<T>&& RHS) noexcept
 {
     // Avoid self-assignment.
     if (this == &RHS)
@@ -1537,7 +1541,7 @@ class GSL_OWNER SmallArray : public SmallArrayImpl<T>
         return *this;
     }
 
-    SmallArray(SmallArray&& RHS)
+    SmallArray(SmallArray&& RHS) noexcept
         : SmallArrayImpl<T>(N)
     {
         if (!RHS.empty())
@@ -1551,7 +1555,7 @@ class GSL_OWNER SmallArray : public SmallArrayImpl<T>
             SmallArrayImpl<T>::operator=(::std::move(RHS));
     }
 
-    SmallArray& operator=(SmallArray&& RHS)
+    SmallArray& operator=(SmallArray&& RHS) noexcept
     {
         if (N) {
             SmallArrayImpl<T>::operator=(::std::move(RHS));

Source/Utility/SettingsFile.h

@@ -121,7 +121,7 @@ class SettingsFile final : public ValueTree::Listener
     ValueTree settingsTree = ValueTree("SettingsTree");
     bool settingsChangedInternally = false;
     bool settingsChangedExternally = false;
-    int64 lastContentHash;
+    int64 lastContentHash = 0;
     static constexpr int64 saveTimeoutMs = 100;
     static constexpr int64 lockTimeoutMs = 5000;