Fix version management when installing .plugdata packages

Author: timothyschoen

Source/Components/WelcomePanel.h

@@ -364,7 +364,7 @@ class WelcomePanel final : public Component
             previousVersions.clear();
 
             for (auto& [time, file] : versions) {
-                auto metaFile = file.getParentDirectory().getChildFile("meta.json");
+                auto metaFile = file.getSiblingFile("meta.json");
                 if (metaFile.existsAsFile()) {
                     auto const json = JSON::fromString(metaFile.loadFileAsString());
                     if (json.hasProperty("Version")) {
@@ -929,13 +929,14 @@ class WelcomePanel final : public Component
         libraryTiles.clear();
 
         auto addTile = [this](Array<std::pair<int64, File>> patches) {
-            auto patchFile = patches[0].second;
-            auto const pName = patchFile.getFileNameWithoutExtension();
-            auto foundThumbs = patchFile.getParentDirectory().findChildFiles(File::findFiles, true, pName + "_thumb.png;" + pName + "_thumb.jpg;" + pName + "_thumb.jpeg;" + pName + "_thumb.gif");
-
+            
             std::ranges::sort(patches, [](std::pair<int64, File> const& first, std::pair<int64, File> const& second) {
                 return first.first > second.first;
             });
+            
+            auto patchFile = patches[0].second;
+            auto const pName = patchFile.getFileNameWithoutExtension();
+            auto foundThumbs = patchFile.getParentDirectory().findChildFiles(File::findFiles, true, pName + "_thumb.png;" + pName + "_thumb.jpg;" + pName + "_thumb.jpeg;" + pName + "_thumb.gif");
 
             patches.remove(0);
 

Source/PluginEditor.cpp

@@ -862,14 +862,15 @@ void PluginEditor::installPackage(File const& file)
 {
     auto zip = ZipFile(file);
     auto patchesDir = ProjectInfo::appDataDir.getChildFile("Patches");
-    auto const result = zip.uncompressTo(patchesDir, false);
+    auto extractedDir = File::createTempFile("");
+    auto const result = zip.uncompressTo(extractedDir, false);
     if (result.wasOk()) {
         auto const macOSTrash = ProjectInfo::appDataDir.getChildFile("Patches").getChildFile("__MACOSX");
         if (macOSTrash.isDirectory()) {
             macOSTrash.deleteRecursively();
         }
 
-        auto extractedLocation = patchesDir.getChildFile(zip.getEntry(0)->filename);
+        auto extractedLocation = extractedDir.getChildFile(zip.getEntry(0)->filename);
         auto const metaFile = extractedLocation.getChildFile("meta.json");
         if (!metaFile.existsAsFile()) {
             PatchInfo info;
@@ -882,8 +883,10 @@ void PluginEditor::installPackage(File const& file)
             info.setInstallTime(Time::currentTimeMillis());
             auto json = info.json;
             metaFile.replaceWithText(info.json);
+            extractedLocation.moveFileTo(patchesDir.getChildFile(info.getNameInPatchFolder()));
         }
 
+        
         Dialogs::showMultiChoiceDialog(&openedDialog, this, "Successfully installed " + file.getFileNameWithoutExtension(), [](int) { }, { "Dismiss" }, Icons::Checkmark);
     }
     else {