Merge pull request #188 from pluginpal/feature/prevent-deadlock

fix: prevent deadlocks from happening by using the native deleteMany …

Author: boazpoolman

.changeset/chilly-melons-sneeze.md

@@ -0,0 +1,5 @@
+---
+"@pluginpal/webtools-core": patch
+---
+
+Prevent deadlocks from happening by using the native deleteMany service

packages/core/server/admin-api/services/bulk-generate.ts

@@ -79,7 +79,7 @@ const generateUrlAliases = async (parms: GenerateParams) => {
   await Promise.all(types.map(async (type) => {
     if (generationType === 'all') {
       // Delete all the URL aliases for the given type.
-      await getPluginService('url-alias').deleteMany({
+      await strapi.entityService.deleteMany('plugin::webtools.url-alias', {
         // @ts-ignore
         locale: 'all',
         filters: {
@@ -90,7 +90,7 @@ const generateUrlAliases = async (parms: GenerateParams) => {
 
     if (generationType === 'only_generated') {
       // Delete all the auto generated URL aliases of the given type.
-      await getPluginService('url-alias').deleteMany({
+      await strapi.entityService.deleteMany('plugin::webtools.url-alias', {
         // @ts-ignore
         locale: 'all',
         filters: {

packages/core/server/content-api/services/url-alias.ts

@@ -1,20 +1,9 @@
 import { factories } from '@strapi/strapi';
-import { EntityService, Common } from '@strapi/types';
 
 /**
  * URL alias service
  */
 
 const contentTypeSlug = 'plugin::webtools.url-alias';
 
-export default factories.createCoreService(contentTypeSlug, ({ strapi }) => ({
-  deleteMany: async (params: EntityService.Params.Pick<Common.UID.ContentType, 'filters'>) => {
-    const toBeDeletedEntities = await strapi.entityService.findMany(contentTypeSlug, params);
-
-    await Promise.all(toBeDeletedEntities.map(async (entity) => {
-      await strapi.entityService.delete(contentTypeSlug, entity.id);
-    }));
-
-    return true;
-  },
-}));
+export default factories.createCoreService(contentTypeSlug);