Skip to content

Commit eedefe2

Browse files
committed
fix: make pattern pages work
1 parent df320e3 commit eedefe2

File tree

7 files changed

+16
-37
lines changed

7 files changed

+16
-37
lines changed

packages/core/admin/components/EditForm/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ const EditForm = () => {
7676
defaultMessage: ' Generate automatic URL alias',
7777
})}
7878
</Checkbox>
79-
<Link href="/plugins/webtools/patterns">Configure URL alias patterns.</Link>
79+
<Link href="/admin/plugins/webtools/patterns">Configure URL alias patterns.</Link>
8080
</Box>
8181
<Box paddingTop={4}>
8282
<Field.Root

packages/core/admin/components/PatternField/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const PatternField: FC<Props> = ({
5454
setLoadingError(true);
5555
setLoading(false);
5656
});
57-
}, [error, get]);
57+
}, [error]);
5858

5959
const HoverBox = styled(Box)`
6060
cursor: pointer;

packages/core/admin/containers/App/index.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ import { Page, useStrapiApp, Layouts } from '@strapi/strapi/admin';
1313

1414
import pluginPermissions from '../../permissions';
1515
import pluginId from '../../helpers/pluginId';
16-
import Patterns from '../../screens/Patterns';
1716
import List from '../../screens/List';
1817
import Overview from '../../screens/Overview';
18+
import PatternsListPage from '../../screens/Patterns/ListPage';
19+
import PatternsEditPage from '../../screens/Patterns/EditPage';
20+
import PatternsCreatePage from '../../screens/Patterns/CreatePage';
1921

2022
const App = () => {
2123
const getPlugin = useStrapiApp('MyComponent', (state) => state.getPlugin);
@@ -61,10 +63,9 @@ const App = () => {
6163
<Routes>
6264
<Route path="/overview" element={<Overview />} />
6365
<Route path="/urls" element={<List />} />
64-
<Route
65-
path="/patterns"
66-
element={<Patterns />}
67-
/>
66+
<Route path="/patterns" element={<PatternsListPage />} />
67+
<Route path="/patterns/new" element={<PatternsCreatePage />} />
68+
<Route path="/patterns/:id" element={<PatternsEditPage />} />
6869
{routerComponents.map(({ Component }) => {
6970
console.log(Component);
7071
return (

packages/core/admin/screens/Patterns/CreatePage/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const CreatePatternPage = () => {
5050
.catch(() => {
5151
setLoading(false);
5252
});
53-
}, [get]);
53+
}, []);
5454

5555
const handleCreateSubmit = async (
5656
values: PatternFormValues,
@@ -147,7 +147,7 @@ const CreatePatternPage = () => {
147147
defaultMessage: 'Add a pattern for automatic URL alias generation.',
148148
})}
149149
navigationAction={(
150-
<Link startIcon={<ArrowLeft />} href={`/plugins/${pluginId}/patterns`}>
150+
<Link startIcon={<ArrowLeft />} href={`/admin/plugins/${pluginId}/patterns`}>
151151
{formatMessage({
152152
id: 'global.back',
153153
defaultMessage: 'Back',

packages/core/admin/screens/Patterns/EditPage/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ const EditPatternPage = () => {
3535
const { formatMessage } = useIntl();
3636
const { get, put, post } = getFetchClient();
3737

38+
console.log('why rerender?');
39+
3840
useEffect(() => {
3941
setLoading(true);
4042
get<EnabledContentTypes>('/webtools/info/getContentTypes')
@@ -46,7 +48,7 @@ const EditPatternPage = () => {
4648
.catch(() => {
4749
setLoading(false);
4850
});
49-
}, [get]);
51+
}, []);
5052

5153
useEffect(() => {
5254
setLoading(true);
@@ -60,7 +62,7 @@ const EditPatternPage = () => {
6062
setLoading(false);
6163
});
6264
// eslint-disable-next-line react-hooks/exhaustive-deps
63-
}, [get, id]);
65+
}, [id]);
6466

6567
const handleEditSubmit = async (
6668
values: PatternFormValues,
@@ -171,7 +173,7 @@ const EditPatternPage = () => {
171173
navigationAction={(
172174
<Link
173175
startIcon={<ArrowLeft />}
174-
href={`/plugins/${pluginId}/patterns`}
176+
href={`/admin/plugins/${pluginId}/patterns`}
175177
>
176178
{formatMessage({
177179
id: 'global.back',

packages/core/admin/screens/Patterns/ListPage/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const ListPatternPage = () => {
3838
fetchData().catch((error) => {
3939
console.error('Failed to fetch data:', error);
4040
});
41-
}, [get]);
41+
}, []);
4242

4343
if (loading) {
4444
return (

packages/core/admin/screens/Patterns/index.tsx

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)