Fix(core): remove Integration of the WebService plugin (#481)

* Fix(core): remove Integration of the WebService plugin

* fix phpstan

Author: stonebuzz

CHANGELOG.md

@@ -13,14 +13,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Escape  data when check if already exist
 - Fix injection of `values in entity tabs` when injecting an `entity`
 - Fix `pdffont` field error for users
+- Move `Notepads` search options to the Black List option
+
 
 ### Added
 
 - Add option to `replace` (instead of `append`)  the value of multiline text fields (e.g. `comment`)
 
-### Fixed
 
-- Move `Notepads` search options to the Black List option
+### Removed
+
+- Integration of the WebService plugin (plugin is no longer maintained)
+
 
 ## [2.14.1] - 2024-12-27
 

hook.php

@@ -27,24 +27,6 @@
  * @link      https://github.com/pluginsGLPI/datainjection
  * -------------------------------------------------------------------------
  */
-
-function plugin_datainjection_registerMethods()
-{
-    /** @var array $WEBSERVICES_METHOD */
-    global $WEBSERVICES_METHOD;
-
-    $methods = ['getModel'      => 'methodGetModel',
-        'listModels'    => 'methodListModels',
-        'inject'        => 'methodInject',
-        'listItemtypes' => 'methodListItemtypes'
-    ];
-
-    foreach ($methods as $code => $method) {
-        $WEBSERVICES_METHOD['datainjection.' . $code] = ['PluginDatainjectionWebservice', $method];
-    }
-}
-
-
 function plugin_datainjection_install()
 {
     /** @var DBmysql $DB */

inc/model.class.php

@@ -1128,21 +1128,7 @@ public function processUploadedFile($options = [])
         $this->loadSpecificModel();
         $response = $this->readUploadedFile($options);
         if (!$this->injectionData) {
-            if (!isset($options['webservice'])) {
-                return false;
-            }
-            if (class_exists('PluginWebservicesMethodCommon')) {
-                return PluginWebservicesMethodCommon::Error(
-                    $options['protocol'],
-                    WEBSERVICES_ERROR_FAILED, /** @phpstan-ignore-line */
-                    sprintf(
-                        __(
-                            'Not data to import',
-                            'datainjection'
-                        )
-                    )
-                );
-            }
+            return false;
         }
 
         if ($mode == self::PROCESS) {
@@ -1154,17 +1140,8 @@ public function processUploadedFile($options = [])
        //There's an error
         if ($check['status'] != PluginDatainjectionCommonInjectionLib::SUCCESS) {
             if ($mode == self::PROCESS) {
-                if (!isset($options['webservice'])) {
-                    Session::addMessageAfterRedirect($check['error_message'], true, ERROR);
-                    return false;
-                }
-                if (class_exists('PluginWebservicesMethodCommon')) {
-                    return PluginWebservicesMethodCommon::Error(
-                        $options['protocol'],
-                        WEBSERVICES_ERROR_FAILED, /** @phpstan-ignore-line */
-                        $check['error_message']
-                    );
-                }
+                Session::addMessageAfterRedirect($check['error_message'], true, ERROR);
+                return false;
             }
         }
 

inc/webservice.class.php

@@ -10,8 +10,6 @@ parameters:
         - inc
         - hook.php
         - setup.php
-    excludePaths:
-        - inc/webservice.class.php
     scanDirectories:
         - ../../inc
         - ../../src

phpstan.neon

@@ -83,8 +83,6 @@ function plugin_init_datainjection()
        // Javascript file
         $PLUGIN_HOOKS['add_javascript']['datainjection'] = 'js/datainjection.js';
 
-       // Inbtegration with Webservices plugin
-        $PLUGIN_HOOKS['webservices']['datainjection'] = 'plugin_datainjection_registerMethods';
         $INJECTABLE_TYPES = [];
     }
 }