Fix certificates expirations dates (#502)

* Fix certificates expirations dates

* Update CHANGELOG

* Fix indentation

* Fix checktype

* Fix infocom update

* Fix php cs

* Fix php cs

* Fix php cs

* Add isNullable is PluginDatainjectionInjectionInterface

* Fix genericobject injection

* Remove isNullable of InjectionInterface

* Update inc/infocominjection.class.php

---------

Co-authored-by: Romain B. <[email protected]>

Author: Lainow

CHANGELOG.md

@@ -5,10 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## [Unreleased]
+## [unreleased] - 
 
 ### Fixed
-
+- Fix injection to the `date_expiration` of certificates
 - Fix the `Task completed` message during plugin update
 
 ## [2.14.3] - 2025-09-16

inc/applianceinjection.class.php

@@ -50,6 +50,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
    /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()
    **/

inc/autoupdatesysteminjection.class.php

@@ -55,6 +55,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
 
     public function getOptions($primary_type = '')
     {

inc/budgetinjection.class.php

@@ -56,6 +56,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
 
     /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()

inc/cartridgeiteminjection.class.php

@@ -55,6 +55,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
 
     /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()

inc/certificateinjection.class.php

@@ -50,6 +50,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
    /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()
    **/
@@ -70,6 +75,9 @@ public function getOptions($primary_type = '')
             "bool"           => [9, 86]
         ];
 
+        // Add date check type to Expiration date Search Option
+        $tab[10]['checktype']    = 'date';
+
         return PluginDatainjectionCommonInjectionLib::addToSearchOptions($tab, $options, $this);
     }
 

inc/commoninjectionlib.class.php

@@ -930,10 +930,10 @@ private function setValueForItemtype($itemtype, $field, $value, $fromdb = false)
         if ($itemtype === User::class && $field === "pdffont" && $fromdb) {
             return;
         }
+        $injectionClass = self::getInjectionClassInstance($itemtype);
        // TODO awfull hack, text ftom CSV set more than once, so check if "another" value
         if (isset($this->values[$itemtype][$field]) && $this->values[$itemtype][$field] != $value) {
            // Data set twice (probably CSV + Additional info)
-            $injectionClass = self::getInjectionClassInstance($itemtype);
             $option = self::findSearchOption($injectionClass->getOptions($itemtype), $field);
 
             if (isset($option['displaytype']) && $option['displaytype'] == 'multiline_text') {
@@ -955,7 +955,7 @@ private function setValueForItemtype($itemtype, $field, $value, $fromdb = false)
             }
         } else { // First value
             if (empty($value)) {
-                if (isForeignKeyField($field) || (strpos($field, 'is_') !== false)) {
+                if (isForeignKeyField($field) || (strpos($field, 'is_') !== false) || (method_exists($injectionClass, 'isNullable') && !$injectionClass->isNullable($field))) {
                     // If the field is an id, we set it to 0
                     $this->values[$itemtype][$field] = self::DROPDOWN_EMPTY_VALUE;
                 } else {
@@ -1596,7 +1596,6 @@ public function processAddOrUpdate()
 
                     foreach ($this->values as $itemtype => $data) {
                        //Do not process primary_type
-
                         if ($itemtype != get_class($item)) {
                             $injectionClass = self::getInjectionClassInstance($itemtype);
                             $item           = new $itemtype();

inc/computer_iteminjection.class.php

@@ -64,6 +64,11 @@ public function connectedTo()
         return $CFG_GLPI["directconnect_types"];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
 
     /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()

inc/computerinjection.class.php

@@ -56,6 +56,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
 
     /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()

inc/computermodelinjection.class.php

@@ -55,6 +55,11 @@ public function connectedTo()
         return [];
     }
 
+    public function isNullable($field)
+    {
+        return true; // By default, all fields can be null
+    }
+
 
     /**
     * @see plugins/datainjection/inc/PluginDatainjectionInjectionInterface::getOptions()