Feat(CI): standardize CI conf (#1091)

* Fix(CI): clean dependencies

* rector

* fix

* fix

Author: Rom1-B

.gitignore

@@ -5,3 +5,4 @@
 .phpunit.result.cache
 tests/files/
 *.min.*
+var/

.php-cs-fixer.php

@@ -5,16 +5,17 @@
 
 $finder = Finder::create()
     ->in(__DIR__)
-    ->name('*.php');
+    ->name('*.php')
+    ->ignoreVCSIgnored(true);
 
 $config = new Config();
 
 $rules = [
-    '@PER-CS2.0'                  => true,
-    'trailing_comma_in_multiline' => ['elements' => ['arguments', 'array_destructuring', 'arrays']], // For PHP 7.4 compatibility
+    '@PER-CS' => true, // Latest PER rules.
 ];
 
 return $config
     ->setRules($rules)
     ->setFinder($finder)
-    ->setUsingCache(false);
+    ->setCacheFile(__DIR__ . '/var/php-cs-fixer/.php-cs-fixer.cache')
+;

ajax/container.php

@@ -52,6 +52,7 @@
     if ($items_id > 0 && !$item->getFromDB($items_id)) {
         throw new NotFoundHttpException();
     }
+
     $item->input = $input;
 
     $display_condition = new PluginFieldsContainerDisplayCondition();

ajax/field_specific_fields.php

@@ -59,9 +59,9 @@
             'multiple'            => true,
         ]);
     } else {
-        $allowed_itemtypes = !empty($field->fields['allowed_values'])
-            ? json_decode($field->fields['allowed_values'])
-            : [];
+        $allowed_itemtypes = empty($field->fields['allowed_values'])
+            ? []
+            : json_decode((string) $field->fields['allowed_values']);
         echo implode(
             ', ',
             array_map(
@@ -72,10 +72,11 @@
             ),
         );
     }
+
     echo '</td>';
 } else {
     $dropdown_matches  = [];
-    $is_dropdown       = $type == 'dropdown' || preg_match('/^dropdown-(?<class>.+)$/', $type, $dropdown_matches) === 1;
+    $is_dropdown       = $type == 'dropdown' || preg_match('/^dropdown-(?<class>.+)$/', (string) $type, $dropdown_matches) === 1;
     $is_dropdown_multi = ($is_dropdown && ($type != 'dropdown-Document'));
 
     // Display "default value(s)" field
@@ -84,10 +85,12 @@
         echo __('Multiple dropdown', 'fields') . ' :';
         echo '<br />';
     }
+
     echo __('Default value', 'fields') . ' :';
     if (in_array($type, ['date', 'datetime'])) {
         echo '<i class="pointer fa fa-info" title="' . __s("You can use 'now' for date and datetime field") . '"></i>';
     }
+
     echo '</td>';
 
     echo '<td>';
@@ -107,6 +110,7 @@
             } else {
                 echo Dropdown::getYesNo($multiple);
             }
+
             echo '<br />';
         } else {
             $multiple = false;
@@ -119,6 +123,7 @@
             if (!$multiple) {
                 echo '<input type="hidden" name="default_value" value="" />';
             }
+
             echo '</em>';
         } else {
             $itemtype = $type == 'dropdown'
@@ -127,6 +132,7 @@
             if ($field->fields['default_value'] === null) {
                 $field->fields['default_value'] = '';
             }
+
             $default_value = $multiple ? json_decode($field->fields['default_value']) : $field->fields['default_value'];
             Dropdown::show(
                 $itemtype,
@@ -139,10 +145,11 @@
                 ],
             );
         }
+
         echo '</div>';
         Ajax::updateItemOnSelectEvent(
-            "dropdown_multiple$rand",
-            "plugin_fields_specific_fields_$rand",
+            'dropdown_multiple' . $rand,
+            'plugin_fields_specific_fields_' . $rand,
             '../ajax/field_specific_fields.php',
             [
                 'id'       => $id,
@@ -159,5 +166,6 @@
             ],
         );
     }
+
     echo '</td>';
 }

composer.json

@@ -4,23 +4,14 @@
         "symfony/yaml": "^7.3"
     },
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "^3.89",
-        "friendsoftwig/twigcs": "^6.1",
-        "glpi-project/tools": "^0.8.3",
-        "php-parallel-lint/php-parallel-lint": "^1.4",
-        "phpstan/extension-installer": "^1.4",
-        "phpstan/phpstan": "^2.1",
-        "phpstan/phpstan-deprecation-rules": "^2.0"
+        "glpi-project/tools": "^0.8.3"
     },
     "config": {
         "optimize-autoloader": true,
         "platform": {
             "php": "8.2.99"
         },
-        "sort-packages": true,
-        "allow-plugins": {
-            "phpstan/extension-installer": true
-        }
+        "sort-packages": true
     },
     "autoload-dev": {
         "psr-4": {