fix(issue): waiting status is not being computed correctly (#3597)

* fix(issue): waiting status is not being computed correctly

* review

Author: MyvTsv

inc/formanswer.class.php

@@ -2005,12 +2005,15 @@ public function getAggregatedStatus(): ?int {
             continue;
          }
          $ticketStatus = PluginFormcreatorCommon::getTicketStatusForIssue($generatedTarget);
-         if ($ticketStatus >= PluginFormcreatorFormAnswer::STATUS_WAITING) {
-            // Ignore tickets refused or pending for validation
-            // getTicketStatusForIssue() does not returns STATUS_ACCEPTED
+         if ($ticketStatus > PluginFormcreatorFormAnswer::STATUS_WAITING) {
             continue;
          }
 
+         // force pending approval status to be seen from to_validate dashboard
+         if ($ticketStatus == PluginFormcreatorFormAnswer::STATUS_WAITING) {
+            return PluginFormcreatorFormAnswer::STATUS_WAITING;
+         }
+
          if ($ticketStatus == CommonITILObject::WAITING) {
             $aggregatedStatus = CommonITILObject::WAITING;
             break;