Fix warning during CLI installation (#314)

* Fix(Core): prevent warning during CLI installation

* apply review

* Apply suggestions from code review

---------

Co-authored-by: Romain B. <[email protected]>

Author: stonebuzz

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [UNRELEASED]
 
+### Fixed
+
+- Fix warning during CLI installation
 
 ## [1.9.1] - 2025-10-27
 

hook.php

@@ -246,7 +246,7 @@ function plugin_mreporting_install()
     $config->createFirstConfig();
 
     PluginMreportingProfile::addRightToAllProfiles();
-    PluginMreportingProfile::addRightToProfile($_SESSION['glpiactiveprofile']['id']);
+    PluginMreportingProfile::addRightToProfile();
 
     return true;
 }

inc/profile.class.php

@@ -204,25 +204,31 @@ public static function getRight()
     * Function to add right on report to a profile
     * @param $idProfile
     */
-    public static function addRightToProfile($idProfile)
+    public static function addRightToProfile(?int $idProfile = null): void
     {
         /** @var DBmysql $DB */
         global $DB;
 
-        //get all reports
+        $profiles_ids = [];
+        $profiles_ids = is_null($idProfile) ? Profile::getSuperAdminProfilesId() : [$idProfile];
+
         $config = new PluginMreportingConfig();
-        foreach ($config->find() as $report) {
-            // add right for any reports for profile
-            // Add manual request because Add function get error : right is set to NULL
-            if (!$DB->updateOrInsert('glpi_plugin_mreporting_profiles', [
-                'profiles_id' => $idProfile,
-                'reports'     => $report['id'],
-                'right'       => READ,
-            ], [
-                'profiles_id' => $idProfile,
-                'reports'     => $report['id'],
-            ])) {
-                return;
+        $reports = $config->find();
+
+        foreach ($profiles_ids as $profileId) {
+            foreach ($reports as $report) {
+                $DB->updateOrInsert(
+                    'glpi_plugin_mreporting_profiles',
+                    [
+                        'profiles_id' => $profileId,
+                        'reports'     => $report['id'],
+                        'right'       => READ,
+                    ],
+                    [
+                        'profiles_id' => $profileId,
+                        'reports'     => $report['id'],
+                    ],
+                );
             }
         }
     }