php cs fixer

Author: Rom1-B

.php-cs-fixer.php

@@ -5,12 +5,14 @@
 
 $finder = Finder::create()
     ->in(__DIR__)
-    ->name('*.php');
+    ->name('*.php')
+    ->ignoreVCSIgnored(true);
 
 $config = new Config();
 
 $rules = [
     '@PER-CS2.0'                  => true,
+    '@PHP84Migration'             => true,
     'trailing_comma_in_multiline' => ['elements' => ['arguments', 'array_destructuring', 'arrays']], // For PHP 7.4 compatibility
 ];
 

inc/alert.class.php

@@ -262,7 +262,7 @@ public static function findAllToNotify($params = [])
         $utable   = PluginNewsAlert_User::getTable();
         $ttable   = PluginNewsAlert_Target::getTable();
         $hidstate = PluginNewsAlert_User::HIDDEN;
-        $users_id = isset($_SESSION['glpiID']) ? $_SESSION['glpiID'] : -1;
+        $users_id = $_SESSION['glpiID'] ?? -1;
         $group_u  = new Group_User();
         $fndgroup = [];
         if (isset($_SESSION['glpiID']) && $fndgroup_user = $group_u->find(['users_id' => $_SESSION['glpiID']])) {
@@ -416,7 +416,7 @@ public function checkDate($datetime)
     {
         if (preg_match('/^(\d{4})-(\d{2})-(\d{2}) (\d{2}):(\d{2}):(\d{2})$/', $datetime)) {
             $datetime                 = explode(' ', $datetime);
-            list($year, $month, $day) = explode('-', $datetime[0]);
+            [$year, $month, $day] = explode('-', $datetime[0]);
 
             return checkdate((int) $month, (int) $day, (int) $year);
         }
@@ -735,9 +735,8 @@ public static function preItemForm($params = [])
         ) {
             $item        = $params['item'];
             $itemtype    = get_class($item);
-            $entities_id = isset($params['item']->fields['entities_id'])
-            ? $params['item']->fields['entities_id']
-            : false; // false to use current entity
+            $entities_id = $params['item']->fields['entities_id']
+            ?? false; // false to use current entity
             self::displayAlerts(['show_only_helpdesk_alerts' => true,
                 'show_hidden_alerts'                         => false,
                 'entities_id'                                => $entities_id,