Fix(SQL): prevent SQL error when column not exist (Item_DeviceSimcard)

Author: stonebuzz

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 - Fix tag search
+- Prevent SQL error when column `name` not exist from `Item_Device`
 
 ## [2.14.3] - 2025-12-22
 

inc/tagitem.class.php

@@ -265,7 +265,9 @@ public static function showForTag(PluginTagTag $tag)
             $item_id = $result2[$i]['items_id'];
 
             if ($item->canView()) {
-                $column = (strtolower(substr((string) $itemtype, 0, 6)) === "device") ? "designation" : "name";
+                $column = (stripos((string) $itemtype, 'item_device') !== false)
+                ? ''
+                : ((stripos((string) $itemtype, 'device') === 0) ? 'designation' : 'name');
 
                 // For rules itemtypes (example : ruledictionnaryphonemodel)
                 if (strtolower(substr((string) $itemtype, 0, 4)) === 'rule' || $itemtype == "PluginResourcesRulechecklist") {
@@ -296,11 +298,14 @@ public static function showForTag(PluginTagTag $tag)
                     'WHERE'      => [
                         'glpi_plugin_tag_tagitems.plugin_tag_tags_id' => $instID,
                     ] + getEntitiesRestrictCriteria($itemtable, '', '', $item->maybeRecursive()),
-                    'ORDERBY'    => [
-                        $itemtable . '.' . $column,
-                    ],
                 ];
 
+                if (!empty($column)) {
+                    $criteria['ORDERBY'] = [
+                        $itemtable . '.' . $column,
+                    ];
+                }
+
                 if ($item->maybeTemplate()) {
                     $criteria['WHERE'][$itemtable . '.is_template'] = 0;
                 }
@@ -339,6 +344,10 @@ public static function showForTag(PluginTagTag $tag)
                                         ],
                                     ],
                                 ];
+                                if (!isset($criteria['ORDERBY']) || !is_array($criteria['ORDERBY'])) {
+                                    $criteria['ORDERBY'] = [];
+                                }
+
                                 array_unshift($criteria['ORDERBY'], 'glpi_entities.completename');
                             } else {
                                 $criteria['SELECT'][] = new QueryExpression('-1 AS ' . $DB::quoteName('entity'));
@@ -364,7 +373,7 @@ public static function showForTag(PluginTagTag $tag)
                         );
                     }
 
-                    $linkname = $data[$column];
+                    $linkname = $data[$column] ?? "";
 
                     if ($_SESSION["glpiis_ids_visible"] || empty($data[$column])) {
                         $linkname = sprintf(__s('%1$s (%2$s)'), $linkname, $data["id"]);