Fix(search): fix tag search criteria (#317)

* Fix(search): fix tag search criteria

* remove useless debug

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* remove useless debug

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* add missing table

---------

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

Author: stonebuzz

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [UNRELEASED]
+
+### Fixed
+
+- Fix tag search
+
+
 ## [2.14.2] - 2025-12-02
 
 ### Fixed

hook.php

@@ -97,11 +97,16 @@ function plugin_tag_getAddSearchOptionsNew($itemtype)
         'searchtype'    => ['equals','notequals','contains'],
         'massiveaction' => false,
         'forcegroupby'  => true,
+        'usehaving'     => true,
         'joinparams'    =>  [
             'beforejoin' => [
                 'table'      => 'glpi_plugin_tag_tagitems',
                 'joinparams' => [
                     'jointype' => 'itemtype_item',
+                    'specific_itemtype' => $itemtype,
+                    'beforejoin' => [
+                        'table' => getTableForItemType($itemtype),
+                    ],
                 ],
             ],
         ],
@@ -172,7 +177,7 @@ function plugin_tag_giveItem($type, $field, $data, $num, $linkfield = "")
 
 function plugin_tag_addHaving($link, $nott, $itemtype, $id, $val, $num)
 {
-    $searchopt = &Search::getOptions($itemtype);
+    $searchopt = Search::getOptions($itemtype);
     $table     = $searchopt[$id]["table"];
     $field     = $searchopt[$id]["field"];
 
@@ -193,7 +198,7 @@ function plugin_tag_addHaving($link, $nott, $itemtype, $id, $val, $num)
 
 function plugin_tag_addWhere($link, $nott, $itemtype, $id, $val, $searchtype)
 {
-    $searchopt = &Search::getOptions($itemtype);
+    $searchopt = Search::getOptions($itemtype);
     $table     = $searchopt[$id]["table"];
     $field     = $searchopt[$id]["field"];
 

tests/fixtures/formcreator.sql

@@ -26,6 +26,27 @@
 -- -------------------------------------------------------------------------
 --
 
+CREATE TABLE IF NOT EXISTS `glpi_plugin_formcreator_formanswers` (
+  `id`                          int unsigned NOT NULL AUTO_INCREMENT,
+  `name`                        varchar(255) NOT NULL DEFAULT '',
+  `entities_id`                 int unsigned NOT NULL DEFAULT '0',
+  `is_recursive`                tinyint(1)   NOT NULL DEFAULT '0',
+  `plugin_formcreator_forms_id` int unsigned NOT NULL DEFAULT '0',
+  `requester_id`                int unsigned NOT NULL DEFAULT '0',
+  `users_id_validator`          int unsigned NOT NULL DEFAULT '0' COMMENT 'User in charge of validation',
+  `groups_id_validator`         int unsigned NOT NULL DEFAULT '0' COMMENT 'Group in charge of validation',
+  `request_date`                timestamp    NULL,
+  `status`                      int(11)      NOT NULL DEFAULT '101',
+  `comment`                     mediumtext,
+  PRIMARY KEY (`id`),
+  INDEX `plugin_formcreator_forms_id` (`plugin_formcreator_forms_id`),
+  INDEX `entities_id_is_recursive` (`entities_id`, `is_recursive`),
+  INDEX `requester_id` (`requester_id`),
+  INDEX `users_id_validator` (`users_id_validator`),
+  INDEX `groups_id_validator` (`groups_id_validator`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci ROW_FORMAT=DYNAMIC;
+
+
 DROP TABLE IF EXISTS `glpi_plugin_formcreator_categories`;
 CREATE TABLE `glpi_plugin_formcreator_categories` (
   `id` int unsigned NOT NULL AUTO_INCREMENT,