Skip to content

Commit 065fe81

Browse files
committed
Fix pylint issue
1 parent 3654dc5 commit 065fe81

File tree

3 files changed

+34
-24
lines changed

3 files changed

+34
-24
lines changed

plugwise_usb/__init__.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
from .api import NodeEvent, PlugwiseNode, StickEvent
1616
from .connection import StickController
17-
from .constants import DEFAULT_CONS_INTERVAL, NO_PRODUCTION_INTERVAL
1817
from .exceptions import MessageError, NodeError, StickError, SubscriptionError
1918
from .network import StickNetwork
2019

@@ -180,24 +179,6 @@ def port(self, port: str) -> None:
180179

181180
self._port = port
182181

183-
async def energy_reset_request(self, mac: str) -> bool:
184-
"""Send an energy-reset request to a Node."""
185-
_LOGGER.debug("Resetting energy logs for %s", mac)
186-
try:
187-
await self._network.energy_reset_request(mac)
188-
except (MessageError, NodeError) as exc:
189-
raise NodeError(f"{exc}") from exc
190-
191-
# Follow up by an energy-intervals (re)set
192-
if (
193-
result := await self.set_energy_intervals(
194-
mac, DEFAULT_CONS_INTERVAL, NO_PRODUCTION_INTERVAL
195-
)
196-
):
197-
return result
198-
199-
return False
200-
201182
async def set_energy_intervals(
202183
self, mac: str, cons_interval: int, prod_interval: int
203184
) -> bool:

plugwise_usb/nodes/circle.py

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323
)
2424
from ..connection import StickController
2525
from ..constants import (
26+
DEFAULT_CONS_INTERVAL,
2627
MAX_TIME_DRIFT,
2728
MINIMAL_POWER_UPDATE,
29+
NO_PRODUCTION_INTERVAL,
2830
PULSES_PER_KW_SECOND,
2931
SECOND_IN_NANOSECONDS,
3032
)
@@ -42,8 +44,7 @@
4244
from ..messages.responses import NodeInfoResponse, NodeResponseType
4345
from .helpers import EnergyCalibration, raise_not_loaded
4446
from .helpers.counter import EnergyCounters
45-
from .helpers.firmware import CIRCLE_FIRMWARE_SUPPORT
46-
from .helpers.pulses import PulseCollection, PulseLogRecord, calc_log_address
47+
from .network import StickNetwork
4748
from .node import PlugwiseBaseNode
4849

4950
CACHE_CURRENT_LOG_ADDRESS = "current_log_address"
@@ -1249,6 +1250,15 @@ async def energy_reset_request(self) -> None:
12491250
)
12501251

12511252
_LOGGER.warning("Energy reset for Node %s successful", self._mac_in_bytes)
1253+
# Follow up by an energy-intervals (re)set
1254+
network = StickNetwork()
1255+
if not (
1256+
result := await network.set_energy_intervals(
1257+
mac, DEFAULT_CONS_INTERVAL, NO_PRODUCTION_INTERVAL
1258+
)
1259+
):
1260+
_LOGGER.warning("Failed enery-intervals (re)set after an energy-reset")
1261+
12521262
# Clear the cached energy_collection
12531263
if self._cache_enabled:
12541264
self._node_cache.update_state(CACHE_ENERGY_COLLECTION, "")
@@ -1263,3 +1273,22 @@ async def energy_reset_request(self) -> None:
12631273
_LOGGER.warning("Node info update failed after energy-reset")
12641274
else:
12651275
_LOGGER.warning("Node info update after energy-reset successful")
1276+
1277+
1278+
async def energy_reset_request(self, mac: str) -> bool:
1279+
"""Send an energy-reset request to a Node."""
1280+
_LOGGER.debug("Resetting energy logs for %s", mac)
1281+
try:
1282+
await self._network.energy_reset_request(mac)
1283+
except (MessageError, NodeError) as exc:
1284+
raise NodeError(f"{exc}") from exc
1285+
1286+
# Follow up by an energy-intervals (re)set
1287+
if (
1288+
result := await self.set_energy_intervals(
1289+
mac, DEFAULT_CONS_INTERVAL, NO_PRODUCTION_INTERVAL
1290+
)
1291+
):
1292+
return result
1293+
1294+
return False

plugwise_usb/nodes/helpers/pulses.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ def pulse_counter_reset(self) -> bool:
165165
return self._cons_pulsecounter_reset or self._prod_pulsecounter_reset
166166

167167
def reset(self) -> None:
168-
"""Reset PulseCollection after e.g. an energy-logs reset."""
169-
mac = self._mac
170-
self.__init__(mac)
168+
"""Reset PulseCollection after an energy-logs reset."""
169+
# Keep mac, wipe every other attribute.
170+
self.__dict__.update(PulseCollection(self._mac).__dict__)
171171

172172
def collected_pulses(
173173
self, from_timestamp: datetime, is_consumption: bool

0 commit comments

Comments
 (0)