Skip to content

Commit 4146840

Browse files
committed
collected_pulses(): don't return None's at rollover
Improve logging
1 parent 01a8ec0 commit 4146840

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

plugwise_usb/nodes/helpers/pulses.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -160,48 +160,48 @@ def collected_pulses(
160160
) -> tuple[int | None, datetime | None]:
161161
"""Calculate total pulses from given timestamp."""
162162
_LOGGER.debug(
163-
"collected_pulses 1 | %s | is_cons=%s, from_timestamp=%s",
163+
"collected_pulses | %s | from_timestamp=%s | is_cons=%s | _log_production=%s",
164164
self._mac,
165-
is_consumption,
166165
from_timestamp,
166+
is_consumption,
167+
self._log_production
167168
)
168-
_LOGGER.debug("collected_pulses 1a | _log_production=%s", self._log_production)
169169
if not is_consumption:
170170
if self._log_production is None or not self._log_production:
171171
return (None, None)
172172

173-
if is_consumption and self._rollover_consumption:
174-
_LOGGER.debug("collected_pulses 2 | %s | _rollover_consumption", self._mac)
175-
return (None, None)
176-
if not is_consumption and self._rollover_production:
177-
_LOGGER.debug("collected_pulses 3 | %s | _rollover_production", self._mac)
178-
return (None, None)
173+
# if is_consumption and self._rollover_consumption:
174+
# _LOGGER.debug("collected_pulses 2 | %s | _rollover_consumption", self._mac)
175+
# return (None, None)
176+
# if not is_consumption and self._rollover_production:
177+
# _LOGGER.debug("collected_pulses 3 | %s | _rollover_production", self._mac)
178+
# return (None, None)
179179

180180
if (
181181
log_pulses := self._collect_pulses_from_logs(from_timestamp, is_consumption)
182182
) is None:
183-
_LOGGER.debug("collected_pulses 4 | %s | log_pulses:None", self._mac)
183+
_LOGGER.debug("collected_pulses | %s | log_pulses:None", self._mac)
184184
return (None, None)
185185

186186
pulses: int | None = None
187187
timestamp: datetime | None = None
188188
if is_consumption and self._pulses_consumption is not None:
189189
pulses = self._pulses_consumption
190190
timestamp = self._pulses_timestamp
191+
191192
if not is_consumption and self._pulses_production is not None:
192193
pulses = self._pulses_production
193194
timestamp = self._pulses_timestamp
194-
# _LOGGER.debug("collected_pulses | %s | pulses=%s", self._mac, pulses)
195195

196196
if pulses is None:
197197
_LOGGER.debug(
198-
"collected_pulses 5 | %s | is_consumption=%s, pulses=None",
198+
"collected_pulses | %s | is_consumption=%s, pulses=None",
199199
self._mac,
200200
is_consumption,
201201
)
202202
return (None, None)
203203
_LOGGER.debug(
204-
"collected_pulses 6 | pulses=%s | log_pulses=%s | consumption=%s at timestamp=%s",
204+
"collected_pulses | pulses=%s | log_pulses=%s | consumption=%s at timestamp=%s",
205205
pulses,
206206
log_pulses,
207207
is_consumption,

0 commit comments

Comments
 (0)