Skip to content

Commit 52ffc37

Browse files
committed
Fix unreachable suppression, a CRAI nitpick
1 parent da98523 commit 52ffc37

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

plugwise_usb/connection/queue.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ async def submit(self, request: PlugwiseRequest) -> PlugwiseResponse | None:
8585
f"Cannot send message {request} which is currently waiting for response."
8686
)
8787

88-
while request.resend:
88+
while True:
89+
if not request.resend:
90+
break
8991
_LOGGER.debug("submit | start (%s) %s", request.retries_left, request)
9092
if not self._running or self._stick is None:
9193
raise StickError(
@@ -107,10 +109,12 @@ async def submit(self, request: PlugwiseRequest) -> PlugwiseResponse | None:
107109
"%s, cancel because timeout is expected for NodePingRequests",
108110
exc,
109111
)
110-
elif request.resend:
112+
continue
113+
if request.resend:
111114
_LOGGER.debug("%s, retrying", exc)
112-
else:
113-
_LOGGER.debug("%s, cancel request", exc) # type: ignore[unreachable]
115+
continue
116+
_LOGGER.debug("%s, cancel request", exc)
117+
break
114118
except StickError as exc:
115119
_LOGGER.error(exc)
116120
raise StickError(

0 commit comments

Comments
 (0)