CR: Fix list modification during iteration

CR: The type annotation uses incorrect syntax.
CR: The registry’s private scan method calls

Author: dirixmjm

plugwise_usb/network/__init__.py

@@ -434,8 +434,8 @@ async def _discover_stragglers(self) -> None:
         """Repeat Discovery of Nodes with unknown NodeType."""
         while len(self._registry_stragglers) > 0:
             await sleep(NODE_RETRY_DISCOVER_INTERVAL)
-            for mac in self._registry_stragglers:
-                if not await self._discover_node(mac, None):
+            for mac in list(self._registry_stragglers):
+                if await self._discover_node(mac, None):
                     self._registry_stragglers.remove(mac)
             _LOGGER.debug(
                 "Total %s nodes unreachable having unknown NodeType",

plugwise_usb/network/cache.py

@@ -78,7 +78,7 @@ def get_nodetype(self, mac: str) -> NodeType | None:
         """Return NodeType from cache."""
         return self._nodetypes.get(mac)
 
-    async def prune_cache(self, registry: list(str)) -> None:
+    async def prune_cache(self, registry: list[str]) -> None:
         """Remove items from cache which are not found in registry scan."""
         _new_nodetypes: dict[str, NodeType] = {}
         for mac in registry:

plugwise_usb/network/registry.py

@@ -99,7 +99,9 @@ def scan_completed(self) -> bool:
         """Indicate if scan is completed."""
         return self._scan_completed
 
-    def start_node_discover(self, callback: Callable[[], Awaitable[None]]) -> None:
+    def start_node_discover(
+        self, callback: Callable[[str, NodeType | None, bool], Awaitable[None]]
+    ) -> None:
         """Register method to be called when a node is found."""
         self._start_node_discover = callback