Skip to content

Commit 82b5da7

Browse files
committed
Correct CirclePlusAllowJoiningRequest response for state=False
1 parent 46b4d60 commit 82b5da7

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

plugwise_usb/messages/responses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class StickResponseType(bytes, Enum):
5656
class NodeResponseType(bytes, Enum):
5757
"""Response types of a 'NodeResponse' reply message."""
5858

59+
CIRCLE_PLUS = b"00DD"
5960
CLOCK_ACCEPTED = b"00D7"
6061
JOIN_ACCEPTED = b"00D9"
6162
RELAY_SWITCHED_OFF = b"00DE"
@@ -69,7 +70,6 @@ class NodeResponseType(bytes, Enum):
6970
SED_CONFIG_FAILED = b"00F7"
7071
POWER_LOG_INTERVAL_ACCEPTED = b"00F8"
7172
POWER_CALIBRATION_ACCEPTED = b"00DA"
72-
CIRCLE_PLUS = b"00DD"
7373

7474

7575
class NodeAckResponseType(bytes, Enum):

plugwise_usb/network/__init__.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
NodeRejoinResponse,
2828
NodeResponseType,
2929
PlugwiseResponse,
30-
StickResponseType,
3130
)
3231
from ..nodes import get_plugwise_node
3332
from .registry import StickNetworkRegister
@@ -520,8 +519,8 @@ async def allow_join_requests(self, state: bool) -> None:
520519
raise NodeError("No response for AllowJoiningRequest request.")
521520

522521
if (
523-
response.response_type != NodeResponseType.JOIN_ACCEPTED
524-
or response.response_type != StickResponseType
522+
response.response_type != NodeResponseType.JOIN_ACCEPTED # state = True
523+
or response.response_type != NodeResponseType.CIRCLE_PLUS # state = False
525524
):
526525
raise MessageError(
527526
f"Unknown NodeResponseType '{response.response_type.name}' received"

0 commit comments

Comments
 (0)