Skip to content

Commit 9ba7808

Browse files
committed
Model_type should be None when not existing
1 parent b560cb9 commit 9ba7808

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

plugwise_usb/nodes/node.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,10 +510,9 @@ async def update_node_details(
510510
self.mac,
511511
hardware,
512512
)
513+
self._node_info.model_type = None
513514
if len(model_info) > 1:
514515
self._node_info.model_type = " ".join(model_info[1:])
515-
else:
516-
self._node_info.model_type = ""
517516
if self._node_info.model is not None:
518517
self._node_info.name = f"{model_info[0]} {self._node_info.mac[-5:]}"
519518
self._set_cache(CACHE_HARDWARE, hardware)

tests/test_usb.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ async def test_stick_node_discovered_subscription(
588588
)
589589
assert stick.nodes["5555555555555555"].node_info.version == "080007"
590590
assert stick.nodes["5555555555555555"].node_info.model == "Scan"
591-
assert stick.nodes["5555555555555555"].node_info.model_type == ""
591+
assert stick.nodes["5555555555555555"].node_info.model_type == None
592592
assert stick.nodes["5555555555555555"].available
593593
assert stick.nodes["5555555555555555"].node_info.is_battery_powered
594594
assert sorted(stick.nodes["5555555555555555"].features) == sorted(
@@ -2531,7 +2531,7 @@ async def test_node_discovery_and_load(
25312531
)
25322532
assert stick.nodes["5555555555555555"].node_info.version == "080007"
25332533
assert stick.nodes["5555555555555555"].node_info.model == "Scan"
2534-
assert stick.nodes["5555555555555555"].node_info.model_type == ""
2534+
assert stick.nodes["5555555555555555"].node_info.model_type == None
25352535
assert stick.nodes["5555555555555555"].available
25362536
assert stick.nodes["5555555555555555"].node_info.is_battery_powered
25372537
assert sorted(stick.nodes["5555555555555555"].features) == sorted(
@@ -2596,7 +2596,7 @@ async def test_node_discovery_and_load(
25962596
)
25972597
assert stick.nodes["8888888888888888"].node_info.version == "070051"
25982598
assert stick.nodes["8888888888888888"].node_info.model == "Switch"
2599-
assert stick.nodes["8888888888888888"].node_info.model_type == ""
2599+
assert stick.nodes["8888888888888888"].node_info.model_type == None
26002600
assert stick.nodes["8888888888888888"].available
26012601
assert stick.nodes["8888888888888888"].node_info.is_battery_powered
26022602
assert sorted(stick.nodes["8888888888888888"].features) == sorted(

0 commit comments

Comments
 (0)