Skip to content

Commit ab7df9e

Browse files
committed
always stop running tasks even on no transport
1 parent c35ebd5 commit ab7df9e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

plugwise_usb/connection/receiver.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,9 @@ def connection_made(self, transport: SerialTransport) -> None:
166166

167167
async def close(self) -> None:
168168
"""Close connection."""
169-
if self._transport is None:
170-
return
171-
self._transport.close()
172169
await self._stop_running_tasks()
170+
if self._transport:
171+
self._transport.close()
173172

174173
async def _stop_running_tasks(self) -> None:
175174
"""Cancel and stop any running task."""
@@ -183,10 +182,12 @@ async def _stop_running_tasks(self) -> None:
183182
cancel_response.priority = Priority.CANCEL
184183
await self._message_queue.put(cancel_response)
185184
await self._message_worker_task
186-
self._message_worker_task = None
185+
self._message_worker_task = None
186+
187187
if self._data_worker_task is not None and not self._data_worker_task.done():
188188
await self._data_queue.put(b"FFFFFFFF")
189189
await self._data_worker_task
190+
self._data_worker_task = None
190191

191192
# region Process incoming data
192193

tests/bandit.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ tests:
1212
- B317
1313
- B318
1414
- B319
15-
- B320
1615
- B601
1716
- B602
1817
- B604

0 commit comments

Comments
 (0)