Skip to content

Commit c1b221b

Browse files
committed
Implement suggested improvements
1 parent 47ea2cc commit c1b221b

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

plugwise_usb/nodes/circle.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -618,22 +618,21 @@ async def energy_log_update(
618618
self._energy_counters.add_empty_log(response.log_address, _slot)
619619
continue
620620

621-
updated = await self._energy_log_record_update_state(
621+
slot_updated = await self._energy_log_record_update_state(
622622
response.log_address,
623623
_slot,
624624
log_timestamp.replace(tzinfo=UTC),
625625
log_pulses,
626626
import_only=True,
627627
)
628-
if updated:
629-
cache_updated = True
628+
cache_updated |= slot_updated
630629

631630
self._energy_counters.update()
632631
if cache_updated:
633632
await self._energy_log_records_save_to_cache()
634633
if save_cache:
635634
_LOGGER.debug(
636-
"Saving energy record update to cache for %s", self._mac_in_str
635+
"Saving and storing energy cache for %s", self._mac_in_str
637636
)
638637
await self.save_cache()
639638

@@ -708,7 +707,7 @@ async def _energy_log_records_load_from_cache(self) -> bool:
708707
return True
709708

710709
async def _energy_log_records_save_to_cache(self) -> None:
711-
"""Save currently collected energy logs to cached file."""
710+
"""Update the in-memory energy log cache string (no file I/O)."""
712711
if not self._cache_enabled:
713712
return
714713

@@ -724,7 +723,7 @@ async def _energy_log_records_save_to_cache(self) -> None:
724723
f"{address}:{slot}:{ts.strftime('%Y-%m-%d-%H-%M-%S')}:{log.pulses}"
725724
)
726725
cached_logs = "|".join(records)
727-
_LOGGER.debug("Saving energy logrecords to cache for %s", self._mac_in_str)
726+
_LOGGER.debug("Updating in-memory energy log records for %s", self._mac_in_str)
728727
self._set_cache(CACHE_ENERGY_COLLECTION, cached_logs)
729728

730729
async def _energy_log_record_update_state(

0 commit comments

Comments
 (0)