codefactor check update

coderabbitai recommendations

Author: dirixmjm

plugwise_usb/api.py

@@ -41,6 +41,7 @@ class NodeFeature(str, Enum):
 
     AVAILABLE = "available"
     BATTERY = "battery"
+    CIRCLEPLUS = "circleplus"
     ENERGY = "energy"
     HUMIDITY = "humidity"
     INFO = "info"
@@ -54,7 +55,6 @@ class NodeFeature(str, Enum):
     SWITCH = "switch"
     SENSE = "sense"
     TEMPERATURE = "temperature"
-    CIRCLEPLUS = "circleplus"
 
 
 class NodeType(Enum):

plugwise_usb/nodes/circle_plus.py

@@ -75,6 +75,7 @@ async def load(self) -> bool:
                 NodeFeature.RELAY_LOCK,
                 NodeFeature.ENERGY,
                 NodeFeature.POWER,
+                NodeFeature.CIRCLEPLUS,
             ),
         )
         if not await self.initialize():
@@ -126,7 +127,16 @@ async def clock_synchronize(self) -> bool:
 
     @raise_not_loaded
     async def enable_auto_join(self) -> bool:
-        """Enable Auto Join."""
-        _LOGGER.info("Allow Auto Joining Enabled")
-        allow_auto_join_request =  CirclePlusAllowJoiningRequest(self._send, True)
-        return await allow_auto_join_request.send()
+        """Enable auto-join on the Circle+.
+
+        Returns:
+           bool: True if the request was acknowledged, False otherwise.
+        """
+        _LOGGER.info("Enabling auto-join for CirclePlus")
+        request = CirclePlusAllowJoiningRequest(self._send, True)
+        response = await request.send()
+        if response is None:
+            return False
+
+        # JOIN_ACCEPTED is the ACK for enable=True
+        return NodeResponseType(response.ack_id) == NodeResponseType.JOIN_ACCEPTED