ruff: PLR2004 static constants (first dash, leaving out work on energy log constants considering ongoing effort

Author: dirixmjm

plugwise_usb/constants.py

@@ -15,6 +15,10 @@
 LOCAL_TIMEZONE = dt.datetime.now(dt.UTC).astimezone().tzinfo
 UTF8: Final = "utf-8"
 
+# Value limits
+MAX_UINT_2: Final = 255
+MAX_UINT_4: Final = 65535
+
 # Time
 DAY_IN_HOURS: Final = 24
 WEEK_IN_HOURS: Final = 168

plugwise_usb/nodes/helpers/pulses.py

@@ -950,7 +950,7 @@ def _last_known_duration(self) -> timedelta:
         if self._logs is None:
             raise EnergyError("Unable to return last known duration without any logs")
 
-        if len(self._logs) < 2:
+        if len(self._logs) < 2:  # noqa: PLR2004
             return timedelta(hours=1)
 
         address, slot = self._last_log_reference()

plugwise_usb/nodes/node.py

@@ -425,7 +425,7 @@ async def _available_update_state(
             if (
                 self._last_seen is not None
                 and timestamp is not None
-                and int((timestamp - self._last_seen).total_seconds()) > 5
+                and int((timestamp - self._last_seen).total_seconds()) > 5  # noqa: PLR2004
 
             ):
                 self._last_seen = timestamp
@@ -659,7 +659,7 @@ def _get_cache_as_datetime(self, setting: str) -> datetime | None:
         """Retrieve value of specified setting from cache memory and return it as datetime object."""
         if (timestamp_str := self._get_cache(setting)) is not None:
             data = timestamp_str.split("-")
-            if len(data) == 6:
+            if len(data) == 6:  # noqa: PLR2004
                 try:
                     return datetime(
                         year=int(data[0]),

plugwise_usb/nodes/scan.py

@@ -11,6 +11,7 @@
 
 from ..api import MotionConfig, MotionSensitivity, MotionState, NodeEvent, NodeFeature
 from ..connection import StickController
+from ..constants import MAX_UINT_2
 from ..exceptions import MessageError, NodeError, NodeTimeout
 from ..messages.requests import ScanConfigureRequest, ScanLightCalibrateRequest
 from ..messages.responses import (
@@ -306,7 +307,7 @@ async def set_motion_reset_timer(self, minutes: int) -> bool:
             self._motion_config.reset_timer,
             minutes,
         )
-        if minutes < 1 or minutes > 255:
+        if minutes < 1 or minutes > MAX_UINT_2:
             raise ValueError(
                 f"Invalid motion reset timer ({minutes}). It must be between 1 and 255 minutes."
             )

plugwise_usb/nodes/sed.py

@@ -19,6 +19,7 @@
 
 from ..api import BatteryConfig, NodeEvent, NodeFeature, NodeInfo
 from ..connection import StickController
+from ..constants import MAX_UINT_2, MAX_UINT_4
 from ..exceptions import MessageError, NodeError
 from ..messages.requests import NodeSleepConfigRequest
 from ..messages.responses import (
@@ -63,6 +64,8 @@
 # Time in minutes the SED will sleep
 SED_DEFAULT_SLEEP_DURATION: Final = 60
 
+# Value limits
+MAX_MINUTE_INTERVAL: Final = 1440
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -232,7 +235,7 @@ async def set_awake_duration(self, seconds: int) -> bool:
             self._battery_config.awake_duration,
             seconds,
         )
-        if seconds < 1 or seconds > 255:
+        if seconds < 1 or seconds > MAX_UINT_2:
             raise ValueError(
                 f"Invalid awake duration ({seconds}). It must be between 1 and 255 seconds."
             )
@@ -262,7 +265,7 @@ async def set_clock_interval(self, minutes: int) -> bool:
             self._battery_config.clock_interval,
             minutes,
         )
-        if minutes < 1 or minutes > 65535:
+        if minutes < 1 or minutes > MAX_UINT_4:
             raise ValueError(
                 f"Invalid clock interval ({minutes}). It must be between 1 and 65535 minutes."
             )
@@ -315,7 +318,7 @@ async def set_maintenance_interval(self, minutes: int) -> bool:
             self._battery_config.maintenance_interval,
             minutes,
         )
-        if minutes < 1 or minutes > 1440:
+        if minutes < 1 or minutes > MAX_MINUTE_INTERVAL:
             raise ValueError(
                 f"Invalid maintenance interval ({minutes}). It must be between 1 and 1440 minutes."
             )
@@ -348,7 +351,7 @@ async def set_sleep_duration(self, minutes: int) -> bool:
             self._battery_config.sleep_duration,
             minutes,
         )
-        if minutes < 1 or minutes > 65535:
+        if minutes < 1 or minutes > MAX_UINT_4:
             raise ValueError(
                 f"Invalid sleep duration ({minutes}). It must be between 1 and 65535 minutes."
             )

plugwise_usb/nodes/sense.py

@@ -20,8 +20,10 @@
 # Sense calculations
 SENSE_HUMIDITY_MULTIPLIER: Final = 125
 SENSE_HUMIDITY_OFFSET: Final = 6
+SENSE_HUMIDITY_LIMIT: Final = 65535
 SENSE_TEMPERATURE_MULTIPLIER: Final = 175.72
 SENSE_TEMPERATURE_OFFSET: Final = 46.85
+SENSE_TEMPERATURE_LIMIT: Final = 65535
 
 SENSE_FEATURES: Final = (
     NodeFeature.INFO,
@@ -111,14 +113,14 @@ async def _sense_report(self, response: PlugwiseResponse) -> bool:
             )
         report_received = False
         await self._available_update_state(True, response.timestamp)
-        if response.temperature.value != 65535:
+        if response.temperature.value != SENSE_TEMPERATURE_LIMIT:
             self._sense_statistics.temperature = float(
                 SENSE_TEMPERATURE_MULTIPLIER * (response.temperature.value / 65536)
                 - SENSE_TEMPERATURE_OFFSET
             )
             report_received = True
 
-        if response.humidity.value != 65535:
+        if response.humidity.value != SENSE_HUMIDITY_LIMIT:
             self._sense_statistics.humidity = float(
                 SENSE_HUMIDITY_MULTIPLIER * (response.humidity.value / 65536)
                 - SENSE_HUMIDITY_OFFSET