CR: implement most of the proposed fixes

Author: dirixmjm

plugwise_usb/api.py

@@ -299,7 +299,6 @@ class SenseStatistics:
     temperature: float | None = None
     humidity: float | None = None
     temperature_state: bool | None = None
-    temperature_state: bool | None = None
     humidity_state: bool | None = None
 
 

plugwise_usb/messages/requests.py

@@ -1430,11 +1430,11 @@ def __init__(  # noqa: PLR0913
     ):
         """Initialize ScanConfigureRequest message object."""
         super().__init__(send_fn, mac)
-        temp_hum_value = 1 if temp_hum else 0
+        temp_hum_value = Int(1 if temp_hum else 0, length=2)
         lower_bound_value = Int(lower_bound, length=4)
         upper_bound_value = Int(upper_bound, length=4)
-        direction_value_1 = 0 if direction else 1
-        direction_value_2 = 1 if direction else 0
+        direction_value_1 = Int(0 if direction else 1, length=2)
+        direction_value_2 = Int(1 if direction else 0, length=2)
         self._args += [
             temp_hum_value,
             lower_bound_value,

plugwise_usb/nodes/sense.py

@@ -377,19 +377,22 @@ async def set_hysteresis_humidity_upper_bound(self, upper_bound: float) -> bool:
             self._hysteresis_config.humidity_upper_bound,
             upper_bound,
         )
-        if upper_bound < 1 or upper_bound > 128:
+        if upper_bound < 1 or upper_bound > 99:
             raise ValueError(
-                "Invalid humidity upper bound {upper_bound}. It must be between 1 and 128 percent."
+                f"Invalid humidity upper bound {upper_bound}. It must be between 1 and 99 percent."
             )
-        if upper_bound < self._hysteresis_config.humidity_lower_bound:
+        if (
+            self._hysteresis_config.humidity_lower_bound is not None
+            and upper_bound < self._hysteresis_config.humidity_lower_bound
+        ):
             raise ValueError(
-                "Invalid humidity upper bound {upper_bound}. It must be equal or above the lower bound {self._hysteresis_config.humidity_lower_bound}."
+                f"Invalid humidity upper bound {upper_bound}. It must be equal or above the lower bound {self._hysteresis_config.humidity_lower_bound}."
             )
         if self._hysteresis_config.humidity_upper_bound == upper_bound:
             return False
         self._hysteresis_config = replace(
             self._hysteresis_config,
-            upper_bound=upper_bound,
+            humidity_upper_bound=upper_bound,
             dirty=True,
         )
         await self._sense_configure_update()
@@ -406,19 +409,22 @@ async def set_hysteresis_humidity_lower_bound(self, lower_bound: float) -> bool:
             self._hysteresis_config.humidity_lower_bound,
             lower_bound,
         )
-        if lower_bound < 1 or lower_bound > 128:
+        if lower_bound < 1 or lower_bound > 99:
             raise ValueError(
-                "Invalid humidity lower bound {lower_bound}. It must be between 1 and 128 percent."
+                f"Invalid humidity lower bound {lower_bound}. It must be between 1 and 99 percent."
             )
-        if lower_bound > self._hysteresis_config.humidity_upper_bound:
+        if (
+            self._hysteresis_config.humidity_upper_bound is not None
+            and lower_bound > self._hysteresis_config.humidity_upper_bound
+        ):
             raise ValueError(
-                "Invalid humidity lower bound {lower_bound}. It must be equal or above the lower bound {self._hysteresis_config.humidity_lower_bound}."
+                f"Invalid humidity lower bound {lower_bound}. It must be equal or above the lower bound {self._hysteresis_config.humidity_lower_bound}."
             )
         if self._hysteresis_config.humidity_lower_bound == lower_bound:
             return False
         self._hysteresis_config = replace(
             self._hysteresis_config,
-            lower_bound=lower_bound,
+            humidity_lower_bound=lower_bound,
             dirty=True,
         )
         await self._sense_configure_update()
@@ -477,19 +483,22 @@ async def set_hysteresis_temperature_upper_bound(self, upper_bound: float) -> bo
             self._hysteresis_config.temperature_upper_bound,
             upper_bound,
         )
-        if upper_bound < 1 or upper_bound > 128:
+        if upper_bound < 1 or upper_bound > 60:
             raise ValueError(
-                "Invalid temperature upper bound {upper_bound}. It must be between 1 and 128 percent."
+                f"Invalid temperature upper bound {upper_bound}. It must be between 1 and 60 degrees."
             )
-        if upper_bound < self._hysteresis_config.temperature_lower_bound:
+        if (
+            self._hysteresis_config.temperature_lower_bound is not None
+            and upper_bound < self._hysteresis_config.temperature_lower_bound
+        ):
             raise ValueError(
-                "Invalid temperature upper bound {upper_bound}. It must be equal or above the lower bound {self._hysteresis_config.temperature_lower_bound}."
+                f"Invalid temperature upper bound {upper_bound}. It must be equal or above the lower bound {self._hysteresis_config.temperature_lower_bound}."
             )
         if self._hysteresis_config.temperature_upper_bound == upper_bound:
             return False
         self._hysteresis_config = replace(
             self._hysteresis_config,
-            upper_bound=upper_bound,
+            temperature_upper_bound=upper_bound,
             dirty=True,
         )
         await self._sense_configure_update()
@@ -506,19 +515,22 @@ async def set_hysteresis_temperature_lower_bound(self, lower_bound: float) -> bo
             self._hysteresis_config.temperature_lower_bound,
             lower_bound,
         )
-        if lower_bound < 1 or lower_bound > 128:
+        if lower_bound < 1 or lower_bound > 60:
             raise ValueError(
-                "Invalid temperature lower bound {lower_bound}. It must be between 1 and 128 percent."
+                f"Invalid temperature lower bound {lower_bound}. It must be between 1 and 60 degrees."
             )
-        if lower_bound > self._hysteresis_config.temperature_upper_bound:
+        if (
+            self._hysteresis_config.temperature_upper_bound is not None
+            and lower_bound > self._hysteresis_config.temperature_upper_bound
+        ):
             raise ValueError(
-                "Invalid temperature lower bound {lower_bound}. It must be equal or below the upper bound {self._hysteresis_config.temperature_upper_bound}."
+                f"Invalid temperature lower bound {lower_bound}. It must be equal or below the upper bound {self._hysteresis_config.temperature_upper_bound}."
             )
         if self._hysteresis_config.temperature_lower_bound == lower_bound:
             return False
         self._hysteresis_config = replace(
             self._hysteresis_config,
-            lower_bound=lower_bound,
+            temperature_lower_bound=lower_bound,
             dirty=True,
         )
         await self._sense_configure_update()
@@ -614,8 +626,13 @@ async def _run_awake_tasks(self) -> None:
         """Execute all awake tasks."""
         await super()._run_awake_tasks()
         if self._hysteresis_config.dirty:
-            await self._configure_sense_humidity_task()
-            await self._configure_sense_temperature_task()
+            configure_result = await gather(
+                self._configure_sense_humidity_task(),
+                self._configure_sense_temperature_task(),
+            )
+            if not all(configure_result):
+                self._hysteresis_config = replace(self._hysteresis_config, dirty=False)
+                await self._sense_configure_update()
 
     async def _configure_sense_humidity_task(self) -> bool:
         """Configure Sense humidity hysteresis device settings. Returns True if successful."""
@@ -662,8 +679,6 @@ async def _configure_sense_humidity_task(self) -> bool:
             _LOGGER.debug(
                 "Successful configure humidity hysteresis settings for %s", self.name
             )
-            self._hysteresis_config = replace(self._hysteresis_config, dirty=False)
-            await self._sense_configure_update()
             return True
 
         _LOGGER.warning(
@@ -718,8 +733,6 @@ async def _configure_sense_temperature_task(self) -> bool:
             _LOGGER.debug(
                 "Successful configure temperature hysteresis settings for %s", self.name
             )
-            self._hysteresis_config = replace(self._hysteresis_config, dirty=False)
-            await self._sense_configure_update()
             return True
 
         _LOGGER.warning(