test improvements recommended by SonarCloud

Author: dirixmjm

tests/test_usb.py

@@ -5,6 +5,7 @@
 from datetime import UTC, datetime as dt, timedelta as td
 import importlib
 import logging
+import math
 import random
 from typing import Any
 from unittest.mock import MagicMock, Mock, patch
@@ -465,7 +466,7 @@ async def test_stick_connect(self, monkeypatch: pytest.MonkeyPatch) -> None:
         await stick.disconnect()
         assert not stick.network_state
         with pytest.raises(pw_exceptions.StickError):
-            assert stick.mac_stick
+            stick.mac_stick
 
     async def disconnected(self, event: pw_api.StickEvent) -> None:  # type: ignore[name-defined]
         """Handle disconnect event callback."""
@@ -611,17 +612,17 @@ async def test_stick_node_discovered_subscription(  # noqa: PLR0915
 
         # Check Scan is raising NodeError for unsupported features
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["5555555555555555"].relay
+            stick.nodes["5555555555555555"].relay
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["5555555555555555"].relay_state
+            stick.nodes["5555555555555555"].relay_state
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["5555555555555555"].switch
+            stick.nodes["5555555555555555"].switch
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["5555555555555555"].power
+            stick.nodes["5555555555555555"].power
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["5555555555555555"].sense
+            stick.nodes["5555555555555555"].sense
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["5555555555555555"].energy
+            stick.nodes["5555555555555555"].energy
 
         # Motion
         self.test_motion_on = asyncio.Future()
@@ -851,11 +852,11 @@ async def test_node_relay_and_power(self, monkeypatch: pytest.MonkeyPatch) -> No
 
         # Check Circle is raising NodeError for unsupported features
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["0098765432101234"].motion
+            stick.nodes["0098765432101234"].motion
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["0098765432101234"].switch
+            stick.nodes["0098765432101234"].switch
         with pytest.raises(pw_exceptions.FeatureError):
-            assert stick.nodes["0098765432101234"].sense
+            stick.nodes["0098765432101234"].sense
 
         # Test relay init
         # load node 2222222222222222 which has
@@ -931,7 +932,9 @@ async def fake_get_missing_energy_logs(address: int) -> None:
             last_second=None, last_8_seconds=None, timestamp=None
         )
         pu = await stick.nodes["0098765432101234"].power_update()
-        assert pu.last_second == 21.2780505980402
+        assert math.isclose(
+            pu.last_second, 21.2780505980402, rel_tol=1e-09, abs_tol=1e-09
+        )
         assert pu.last_8_seconds == -27.150578775440106
 
         # Test energy state without request
@@ -1392,7 +1395,12 @@ def test_energy_counter(self) -> None:
             0.07204743061527973,
             reset_timestamp,
         )
-        assert energy_counter_init.energy == 0.07204743061527973
+        assert math.isclose(
+            energy_counter_init.energy,
+            0.07204743061527973,
+            rel_tol=1e-09,
+            abs_tol=1e-09,
+        )
         assert energy_counter_init.last_reset == reset_timestamp
         assert energy_counter_init.last_update == reset_timestamp + td(minutes=10)
 
@@ -1401,7 +1409,12 @@ def test_energy_counter(self) -> None:
             0.08263379198066137,
             reset_timestamp,
         )
-        assert energy_counter_init.energy == 0.08263379198066137
+        assert math.isclose(
+            energy_counter_init.energy,
+            0.08263379198066137,
+            rel_tol=1e-09,
+            abs_tol=1e-09,
+        )
         assert energy_counter_init.last_reset == reset_timestamp
         assert energy_counter_init.last_update == reset_timestamp + td(
             minutes=15, seconds=10