Skip to content

Commit 045ce33

Browse files
committed
Add missing returns
1 parent 9bc33d1 commit 045ce33

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

tests/test_init.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -858,13 +858,17 @@ async def tinker_dhw_mode(smile, unhappy=False):
858858
try:
859859
await smile.set_select("select_dhw_mode", "dummy", mode)
860860
_LOGGER.info(" + tinker_dhw_mode worked as intended")
861+
return True
861862
except pw_exceptions.PlugwiseError:
862863
_LOGGER.info(" + tinker_dhw_mode found invalid mode, as expected")
864+
return False
863865
except pw_exceptions.ConnectionFailedError:
864866
if unhappy:
865867
_LOGGER.info(" + failed as expected before intended failure")
868+
return True
866869
else: # pragma: no cover
867870
_LOGGER.info(" - succeeded unexpectedly for some reason")
871+
return False
868872

869873
@staticmethod
870874
async def tinker_regulation_mode(smile, unhappy=False):
@@ -878,15 +882,19 @@ async def tinker_regulation_mode(smile, unhappy=False):
878882
try:
879883
await smile.set_select("select_regulation_mode", "dummy", mode)
880884
_LOGGER.info(" + tinker_regulation_mode worked as intended")
885+
return True
881886
except pw_exceptions.PlugwiseError:
882887
_LOGGER.info(
883888
" + tinker_regulation_mode found invalid mode, as expected"
884889
)
890+
return False
885891
except pw_exceptions.ConnectionFailedError:
886892
if unhappy:
887893
_LOGGER.info(" + failed as expected before intended failure")
894+
return True
888895
else: # pragma: no cover
889896
_LOGGER.info(" - succeeded unexpectedly for some reason")
897+
return False
890898

891899
@staticmethod
892900
async def tinker_max_boiler_temp(smile, unhappy=False):
@@ -897,14 +905,17 @@ async def tinker_max_boiler_temp(smile, unhappy=False):
897905
try:
898906
await smile.set_number("dummy", test, new_temp)
899907
_LOGGER.info(" + tinker_max_boiler_temp worked as intended")
908+
return True
900909
except pw_exceptions.PlugwiseError:
901910
_LOGGER.info(" + tinker_max_boiler_temp failed as intended")
911+
return False
902912
except pw_exceptions.ConnectionFailedError:
903913
if unhappy:
904914
_LOGGER.info(" + failed as expected before intended failure")
915+
return True
905916
else: # pragma: no cover
906917
_LOGGER.info(" - succeeded unexpectedly for some reason")
907-
918+
return False
908919

909920
@staticmethod
910921
async def tinker_temp_offset(smile, dev_id, unhappy=False):
@@ -938,13 +949,17 @@ async def tinker_gateway_mode(smile, unhappy=False):
938949
try:
939950
await smile.set_select("select_gateway_mode", "dummy", mode)
940951
_LOGGER.info(" + worked as intended")
952+
return True
941953
except pw_exceptions.PlugwiseError:
942954
_LOGGER.info(" + found invalid mode, as expected")
955+
return False
943956
except pw_exceptions.ConnectionFailedError:
944957
if unhappy:
945958
_LOGGER.info(" + failed as expected before intended failure")
959+
return True
946960
else: # pragma: no cover
947961
_LOGGER.info(" - succeeded unexpectedly for some reason")
962+
return False
948963

949964
@staticmethod
950965
def validate_test_basics(

0 commit comments

Comments
 (0)