Skip to content

Commit 0c0ecd7

Browse files
committed
Improve _add_member()
1 parent e6951c0 commit 0c0ecd7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

plugwise/common.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def _get_groups(self) -> None:
212212
group_type = group.find("type").text
213213
group_appliances = group.findall("appliances/appliance")
214214
for item in group_appliances:
215-
self._add_member(item)
215+
self._add_member(item, members)
216216

217217
if group_type in GROUP_TYPES and members and group_id:
218218
self.gw_entities[group_id] = {
@@ -234,8 +234,8 @@ def _get_groups(self) -> None:
234234

235235
def _add_member(self, element: etree.Element, members: list[str]) -> None:
236236
"""Check and add member to list."""
237-
if element.attrib["id"] in self.gw_entities:
238-
members.append(item.attrib["id"])
237+
if (member_id := element.attrib["id"]) in self.gw_entities:
238+
members.append(member_id)
239239

240240
def _get_lock_state(
241241
self, xml: etree.Element, data: GwEntityData, stretch_v2: bool = False

0 commit comments

Comments
 (0)