Skip to content

Commit 0c5dd9a

Browse files
committed
Correct tinker_legacy_thermostat_temp() logic
1 parent 9e7a8cb commit 0c5dd9a

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tests/test_init.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -699,30 +699,33 @@ async def tinker_thermostat_temp(
699699
tinker_temp_passed = True
700700
else: # pragma: no cover
701701
_LOGGER.info(" - tinker_thermostat_temp failed unexpectedly")
702-
return False
702+
tinker_temp_passed = False
703703

704704
return tinker_temp_passed
705705

706706
@pytest.mark.asyncio
707707
async def tinker_legacy_thermostat_temp(self, smile, unhappy=False):
708708
"""Toggle temperature to test functionality."""
709709
_LOGGER.info("Assert modifying temperature setpoint")
710+
tinker_temp_passed = False
710711
test_temp = 22.9
711712
_LOGGER.info("- Adjusting temperature to %s", test_temp)
712713
try:
713714
await smile.set_temperature(test_temp, None)
714715
_LOGGER.info(" + worked as intended")
715-
return True
716+
tinker_temp_passed = True
716717
except (
717718
pw_exceptions.ErrorSendingCommandError,
718719
pw_exceptions.ResponseError,
719720
):
720721
if unhappy:
721722
_LOGGER.info(" + failed as expected")
722-
return True
723+
tinker_temp_passed = True
723724
else: # pragma: no cover
724725
_LOGGER.info(" - failed unexpectedly")
725-
return True
726+
tinker_temp_passed = False
727+
728+
return tinker_temp_passed
726729

727730
@pytest.mark.asyncio
728731
async def tinker_thermostat_preset(self, smile, loc_id, unhappy=False):

0 commit comments

Comments
 (0)