Remove mac obfuscation - Change p1 legacy

Author: CoMPaTech

scripts/pre-commit.sh

@@ -1,5 +1,4 @@
 #!/usr/bin/env bash
-grep -r --include="*.xml" '<mac_address>' userdata/* | grep -v '01234567' && echo "COMMIT REJECTED, found a mac-address, modify domain_objects and modules and set mac-address to 01234567....! (last 4 digits can remain)" && exit 1
 grep -r --include="*.xml" '<short_id>' userdata/* | grep -v 'abcdefgh' && echo "COMMIT REJECTED, found a real short_id, modify domain_objects and set short_id to abcdefgh!" && exit 1
 grep -r --include="*.xml" '<wifi_ip>' userdata/* | grep -v '_ip></wifi' | grep -v '127.0.0.' && echo "COMMIT REJECTED, found a WIFI ip address, modify domain_objects and set wifi_ip to 127.0.0.1!" && exit 1
 grep -r --include="*.xml" 'lan_ip>' userdata/* | grep -v '_ip></lan' | grep -v '127.0.0.' && echo "COMMIT REJECTED, found a LAN ip address, modify domain_objects and set lan_ip to 127.0.0.1!" && exit 1
@@ -9,6 +8,5 @@ grep -r --include="*.xml" '<longitude>' userdata/* | grep -v '4.49' && echo "COM
 grep -r --include="*.xml" '<latitude>' userdata/* | grep -v '52.21' && echo "COMMIT REJECTED, found your hometown, modify domain_objects and set latitude to 52.21 (that is: Plugwise HQ)!" && exit 1
 grep -r --include="*.xml" '<city>' userdata/* | grep -v 'Sassenheim' && echo "COMMIT REJECTED, found your hometown, modify domain_objects and set city to Sassenheim (that is: Plugwise HQ)!" && exit 1
 grep -r --include="*.xml" '<postal_code>' userdata/* | grep -v '2171' && echo "COMMIT REJECTED, found your hometown, modify domain_objects and set postal_code to 2171 (that is: Plugwise HQ)!" && exit 1
-grep -r --include="*.xml" '<mac>' userdata/* | grep -v '01:23:45:67:' && echo "COMMIT REJECTED, found a mac-address, modify system_status and set mac-address to 01:23:45:67:..:..! (last 4 digits can remain)" && exit 1
 # No problems found
 exit 0

userdata/README.md

@@ -48,7 +48,22 @@ Don't commit test-data in `tests` that shouldn't be available to 'the internet'.
 To prevent this we've included a pre-commit hook that checks and validates that no private information is there (but do double-check yourselves!)
 See 'pre-commit.sh' for details
 
-### Manual renumbering mac-addresses
+### Excerpt:
+
+ - [ ] modify `domain_objects` and set `short_id` to `abcdefgh`
+ - [ ] modify `domain_objects` and set `wifi_ip` to `127.0.0.2`
+ - [ ] modify `domain_objects` and set `lan_ip` to `127.0.0.1`
+ - [ ] modify `domain_objects` and set all `ip_addresses` to `127.0.0.3`
+ - [ ] modify `domain_objects` and set `hostname` to `smile000000`
+ - [ ] modify `domain_objects` and set `longitude` to `4.49`
+ - [ ] modify `domain_objects` and set `latitude` to `52.21`
+ - [ ] modify `domain_objects` and set `city` to `Sassenheim`
+ - [ ] modify `domain_objects` and set `postal_code` to `2171`
+
+### Obfuscating mac-addresses
+
+We used to obfuscate them as they weren't used within our module nor HomeAssistant.
+With 0.16.4 this was changed as such we recommend leaving them in, if you do wish to obfuscate
 
 Prefix: 
 
@@ -62,15 +77,3 @@ Postfix:
     - 0101 = Controller Zigbee Mac Address
     - 0Axx = Nodes Zigbee mac addresses
 
-### Excerpt:
-
- - [ ] modify `domain_objects` and `modules` and set all occurrences of `mac-address` to `01234567????` (i.e. leave the last 4 digits as they are)
- - [ ] modify `domain_objects` and set `short_id` to `abcdefgh`
- - [ ] modify `domain_objects` and set `wifi_ip` to `127.0.0.2`
- - [ ] modify `domain_objects` and set `lan_ip` to `127.0.0.1`
- - [ ] modify `domain_objects` and set all `ip_addresses` to `127.0.0.3`
- - [ ] modify `domain_objects` and set `hostname` to `smile000000`
- - [ ] modify `domain_objects` and set `longitude` to `4.49`
- - [ ] modify `domain_objects` and set `latitude` to `52.21`
- - [ ] modify `domain_objects` and set `city` to `Sassenheim`
- - [ ] modify `domain_objects` and set `postal_code` to `2171`

userdata/smile_p1_v2/system_status_xml.xml

@@ -18,7 +18,7 @@
 <hostname>smile000000</hostname>
 <type>LAN (cable)</type>
 <ip_address>127.0.0.1</ip_address>
-<mac_address>0123456789AB</mac_address>
+<mac_address>012345670001</mac_address>
 </network>
 </status>
 

userdata/smile_p1_v2_2/system_status_xml.xml

@@ -18,6 +18,6 @@
 <hostname>smile000000</hostname>
 <type>LAN (cable)</type>
 <ip_address>127.0.0.1</ip_address>
-<mac_address>0123456789AB</mac_address>
+<mac_address>012345670001</mac_address>
 </network>
 </status>