Merge pull request #163 from plugwise/outdoor_temp

Rename outdoor_temp sensor

Author: bouwew

CHANGELOG.md

@@ -1,7 +1,8 @@
 # Changelog
 
-# v0.16.9a0 - Smile: bugfix
+# v0.16.9a1 - Smile: bugfix and improve
 - Fix for https://github.com/plugwise/plugwise-beta/issues/250
+- Rename heatpump outdoor_temperature sensor to outdoor_unit_temperature sensor
 
 # v0.16.8 - Smile: bugfixes, continued
 - Fix for https://github.com/home-assistant/core/issues/68003

plugwise/__init__.py

@@ -1,6 +1,6 @@
 """Plugwise module."""
 
-__version__ = "0.16.9a0"
+__version__ = "0.16.9a1"
 
 from plugwise.smile import Smile
 from plugwise.stick import Stick

plugwise/constants.py

@@ -417,8 +417,6 @@
     "thermostat": {ATTR_NAME: "setpoint", ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS},
     # Specific for an Anna
     "illuminance": {ATTR_UNIT_OF_MEASUREMENT: UNIT_LUMEN},
-    # Outdoor temperature from APPLIANCES - present for a heatpump
-    "outdoor_temperature": {ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS},
     # Schedule temperature - only present for a legacy Anna or an Anna v3
     "schedule_temperature": {ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS},
     # Specific for an Anna with heatpump extension installed
@@ -489,6 +487,11 @@
         ATTR_NAME: "heating_state",
         ATTR_UNIT_OF_MEASUREMENT: None,
     },
+    # Outdoor temperature from APPLIANCES - present for a heatpump
+    "outdoor_temperature": {
+        ATTR_NAME: "outdoor_unit_temperature",
+        ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
+    },
 }
 
 # Known types of Smiles and Stretches
@@ -575,6 +578,7 @@
     "net_electricity_cumulative",
     "net_electricity_point",
     "outdoor_temperature",
+    "outdoor_unit_temperature",
     "return_temperature",
     "setpoint",
     "temperature_difference",

plugwise/helper.py

@@ -826,7 +826,7 @@ def _appliance_measurements(
                     self._cooling_activation_outdoor_temp = data.get(measurement)
                 if measurement == "cooling_deactivation_threshold":
                     self._cooling_deactivation_threshold = data.get(measurement)
-                if measurement == "outdoor_temperature":
+                if measurement == "outdoor_unit_temperature":
                     self._outdoor_temp = data.get(measurement)
 
             i_locator = f'.//logs/interval_log[type="{measurement}"]/period/measurement'

tests/test_smile.py

@@ -2215,7 +2215,7 @@ async def test_connect_anna_heatpump(self):
                     "heating_state": True,
                 },
                 "sensors": {
-                    "outdoor_temperature": 3.0,
+                    "outdoor_unit_temperature": 3.0,
                     "water_temperature": 29.1,
                     "water_pressure": 1.57,
                 },
@@ -2274,7 +2274,7 @@ async def test_connect_anna_heatpump_cooling(self):
                     "heating_state": False,
                 },
                 "sensors": {
-                    "outdoor_temperature": 22.0,
+                    "outdoor_unit_temperature": 22.0,
                     "water_temperature": 24.7,
                     "water_pressure": 1.61,
                 },
@@ -2331,7 +2331,7 @@ async def test_connect_anna_heatpump_cooling_to_off(self):
                     "heating_state": False,
                 },
                 "sensors": {
-                    "outdoor_temperature": 3.0,
+                    "outdoor_unit_temperature": 3.0,
                     "water_temperature": 24.7,
                     "water_pressure": 1.61,
                 },
@@ -2408,7 +2408,7 @@ async def test_connect_anna_elga_2(self):
                     "flame_state": False,
                 },
                 "sensors": {
-                    "outdoor_temperature": 14.0,
+                    "outdoor_unit_temperature": 14.0,
                     "water_temperature": 22.8,
                     "intended_boiler_temperature": 0.0,
                     "modulation_level": 0.0,