Skip to content

Commit 1a8e8eb

Browse files
bouwewfrenck
andauthored
Apply suggestions from code review
Co-authored-by: Franck Nijhof <[email protected]>
1 parent b1edc9c commit 1a8e8eb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

plugwise/helper.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,12 @@ def schemas_schedule_temp(schedules, name) -> float | None:
130130

131131
def types_finder(data) -> set:
132132
"""Detect types within locations from logs."""
133-
types: set = set()
133+
types = set()
134134
for measure, attrs in HOME_MEASUREMENTS.items():
135-
locator: str = f".//logs/point_log[type='{measure}']"
135+
locator = f".//logs/point_log[type='{measure}']"
136136
if data.find(locator) is not None:
137137
log: etree = data.find(locator)
138-
p_locator: str = ".//electricity_point_meter"
138+
p_locator = ".//electricity_point_meter"
139139
if log.find(p_locator) is not None:
140140
if log.find(p_locator).get("id"):
141141
types.add(attrs[ATTR_TYPE])
@@ -1163,7 +1163,7 @@ def _last_used_schedule(self, loc_id, rule_ids) -> str | None:
11631163
if not rule_ids:
11641164
return # pragma: no cover
11651165

1166-
for rule_id, dummy in rule_ids.items():
1166+
for rule_id in rule_ids:
11671167
schema_name: str = self._domain_objects.find(
11681168
f'rule[@id="{rule_id}"]/name'
11691169
).text

0 commit comments

Comments
 (0)