Skip to content

Commit 205265e

Browse files
committed
Improve _get_groups()
Try 4
1 parent 1c74c51 commit 205265e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

plugwise/common.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,13 @@ def _get_groups(self) -> None:
208208
if group_id is None:
209209
continue # pragma: no cover
210210

211-
members = self._collect_members(group)
212-
if group_id not in self._existing_groups and members:
211+
if (members := self._collect_members(group)):
213212
self._new_groups.append(group_id)
214-
elif self.gw_entities[group_id]["name"] == group_name:
213+
214+
if (
215+
group_id in self._existing_groups
216+
and self.gw_entities[group_id]["name"] == group_name
217+
):
215218
continue
216219

217220
group_type = group.find("type").text

0 commit comments

Comments
 (0)