Mark todos and indicate walrus refactor

Author: CoMPaTech

plugwise/connections/__init__.py

@@ -27,7 +27,7 @@ def __init__(self, port, parser):
         self._writer_thread = None
 
     ################################################
-    ###             Open connection              ###
+    #               Open connection                #
     ################################################
 
     def connect(self) -> bool:
@@ -40,7 +40,7 @@ def _open_connection(self):
         """Placeholder."""
 
     ################################################
-    ###                   Reader                 ###
+    #                     Reader                   #
     ################################################
 
     def _reader_start(self, name):
@@ -58,14 +58,14 @@ def _reader_deamon(self):
             time.sleep(0.01)
         _LOGGER.debug("Reader daemon stopped")
 
-    #  TODO: function instead of self
+    #  TODO: 20220125 function instead of self
     #  pylint: disable=no-self-use
     def _read_data(self):
         """placeholder."""
         return b"0000"
 
     ################################################
-    ###                 Writer                   ###
+    #                   Writer                     #
     ################################################
 
     def _writer_start(self, name: str):
@@ -103,7 +103,7 @@ def send(self, message: NodeRequest, callback=None):
         self._write_queue.put_nowait((message, callback))
 
     ################################################
-    ###             Connection state             ###
+    #               Connection state               #
     ################################################
 
     def is_connected(self):
@@ -119,7 +119,7 @@ def write_thread_alive(self):
         return self._writer_thread.is_alive() if self.run_writer_thread else False
 
     ################################################
-    ###             Close connection             ###
+    #               Close connection               #
     ################################################
 
     def disconnect(self):

plugwise/helper.py

@@ -443,6 +443,8 @@ def _get_module_data(self, appliance, locator, mod_type):
         if appl_search is not None:
             link_id = appl_search.attrib["id"]
             locator = f".//{mod_type}[@id='{link_id}']...."
+            #  TODO: 20220125 investigate why walrus doesn't play with pylint (module.find = no-member) on
+            #        if (module := self._modules.find(locator)) is not None:
             module = self._modules.find(locator)
             if module is not None:
                 v_name = module.find("vendor_name").text

plugwise/messages/responses.py

@@ -337,7 +337,7 @@ def __init__(self):
         self.datetime = DateTime()
         self.last_logaddr = LogAddr(0, length=8)
         self.relay_state = Int(0, length=2)
-        #  TODO: snake-style
+        #  TODO: 20220126 snake-style
         #  pylint: disable=invalid-name
         self.hz = Int(0, length=2)
         self.hw_ver = String(None, length=12)

plugwise/nodes/scan.py

@@ -97,13 +97,13 @@ def _process_switch_group(self, message):
                 self.mac,
             )
 
-    #  TODO: snakestyle name
+    #  TODO: 20220125 snakestyle name
     #  pylint: disable=invalid-name
     def CalibrateLight(self, callback=None):
         """Queue request to calibration light sensitivity"""
         self._queue_request(ScanLightCalibrateRequest(self._mac), callback)
 
-    #  TODO: snakestyle name
+    #  TODO: 20220125 snakestyle name
     #  pylint: disable=invalid-name
     def Configure_scan(
         self,
@@ -130,7 +130,7 @@ def Configure_scan(
             callback,
         )
 
-    #  TODO: snakestyle name
+    #  TODO: 20220125 snakestyle name
     #  pylint: disable=invalid-name
     def SetMotionAction(self, callback=None):
         """Queue Configure Scan to signal motion"""

plugwise/nodes/sed.py

@@ -135,7 +135,7 @@ def _wake_up_interval_accepted(self):
         """Callback after wake up interval is received and accepted by SED."""
         self._wake_up_interval = self._new_maintenance_interval
 
-    #  TODO: snakestyle name
+    #  TODO: 20220125 snakestyle name
     #  pylint: disable=invalid-name
     def Configure_SED(
         self,