Fix raise from ... as suggested

Author: bouwew

plugwise/helper.py

@@ -164,9 +164,9 @@ async def _request_validate(self, resp: ClientResponse, method: str) -> etree:
         try:
             # Encode to ensure utf8 parsing
             xml = etree.XML(escape_illegal_xml_characters(result).encode())
-        except etree.ParseError:
+        except etree.ParseError as exc:
             LOGGER.warning("Smile returns invalid XML for %s", self._endpoint)
-            raise InvalidXMLError
+            raise InvalidXMLError from exc
 
         return xml
 
@@ -202,15 +202,15 @@ async def _request(
                 )
         except (
             ClientError
-        ) as err:  # ClientError is an ancestor class of ServerTimeoutError
+        ) as exc:  # ClientError is an ancestor class of ServerTimeoutError
             if retry < 1:
                 LOGGER.warning(
                     "Failed sending %s %s to Plugwise Smile, error: %s",
                     method,
                     command,
-                    err,
+                    exc,
                 )
-                raise ConnectionFailedError
+                raise ConnectionFailedError from exc
             return await self._request(command, retry - 1)
 
         return await self._request_validate(resp, method)

tests/test_init.py

@@ -183,8 +183,8 @@ async def smile_status(self, request):
             with open(userdata, encoding="utf-8") as filedata:
                 data = filedata.read()
             return aiohttp.web.Response(text=data)
-        except OSError:
-            raise aiohttp.web.HTTPNotFound
+        except OSError as exc:
+            raise aiohttp.web.HTTPNotFound from exc
 
     @classmethod
     async def smile_http_accept(cls, request):
@@ -317,9 +317,9 @@ async def connect_wrapper(
                 await self.connect(fail_auth=fail_auth)
                 _LOGGER.error(" - invalid credentials not handled")  # pragma: no cover
                 raise self.ConnectError  # pragma: no cover
-            except pw_exceptions.InvalidAuthentication:
+            except pw_exceptions.InvalidAuthentication as exc:
                 _LOGGER.info(" + successfully aborted on credentials missing.")
-                raise pw_exceptions.InvalidAuthentication
+                raise pw_exceptions.InvalidAuthentication from exc
 
         if raise_timeout:
             _LOGGER.warning("Connecting to device exceeding timeout in handling:")