Merge pull request #367 from plugwise/fix-ruff-noqa

 Fix issue introduced by ruff: replace using .keys() in xml-find result

Author: bouwew

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Ongoing
+
+- Fix issue introduced by ruff: replace using .keys() in xml-find result
+
 ## v0.31.9: Further typing improvements
 
 - Add NumberType, SelectType and SelectOptionsType constants to improve typing further

plugwise/helper.py

@@ -76,6 +76,16 @@
 # from typing import cast
 
 
+def etree_to_dict(element: etree) -> dict[str, str]:
+    """Helper-function translating xml Element to dict."""
+    node: dict[str, str] = {}
+    getattr(element, "text", None)
+    if element is not None:
+        node.update(element.items())
+
+    return node
+
+
 def update_helper(
     data: DeviceData,
     devices: dict[str, DeviceData],
@@ -1303,10 +1313,12 @@ def _preset(self, loc_id: str) -> str | None:
 
         locator = "./rule[active='true']/directives/when/then"
         if (
-            active_rule := self._domain_objects.find(locator)
-        ) is None or "icon" not in active_rule.keys():  # noqa: SIM118
+            not (active_rule := etree_to_dict(self._domain_objects.find(locator)))
+            or "icon" not in active_rule
+        ):
             return None
-        return str(active_rule.attrib["icon"])
+
+        return active_rule["icon"]
 
     def _schedules_legacy(
         self, avail: list[str], sel: str