Shellcheck

Author: CoMPaTech

.pre-commit-config.yaml

@@ -55,6 +55,13 @@ repos:
     hooks:
       - id: yamllint
         name: "YAML linting"
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.10.0.1
+    hooks:
+      - id: shellcheck
+        name: "Shell checking"
+        args:
+          - --external-sources
   - repo: https://github.com/cdce8p/python-typing-update
     rev: v0.7.2
     hooks:

scripts/complexity.sh

@@ -4,13 +4,15 @@ set -eu
 my_path=$(git rev-parse --show-toplevel)
 
 if [ -n "${VIRTUAL_ENV-}" ] && [ -f "${VIRTUAL_ENV}/bin/activate" ]; then
+  # shellcheck disable=SC1091 # ingesting virtualenv
   . "${VIRTUAL_ENV}/bin/activate"
 else
   # other common virtualenvs
   my_path=$(git rev-parse --show-toplevel)
 
   for venv in venv .venv .; do
     if [ -f "${my_path}/${venv}/bin/activate" ]; then
+      # shellcheck disable=SC1090 # ingesting virtualenv
       . "${my_path}/${venv}/bin/activate"
       break
     fi

scripts/run-in-env.sh

@@ -15,13 +15,15 @@ if [ -s .python-version ]; then
 fi
 
 if [ -n "${VIRTUAL_ENV-}" ] && [ -f "${VIRTUAL_ENV}/bin/activate" ]; then
+  # shellcheck disable=SC1091 # ingesting virtualenv
   . "${VIRTUAL_ENV}/bin/activate"
 else
   # other common virtualenvs
   my_path=$(git rev-parse --show-toplevel)
 
   for venv in venv .venv .; do
     if [ -f "${my_path}/${venv}/bin/activate" ]; then
+      # shellcheck disable=SC1090 # ingesting virtualenv
       . "${my_path}/${venv}/bin/activate"
       break
     fi

scripts/setup.sh

@@ -1,10 +1,8 @@
 #!/usr/bin/env bash
-# 20250613 Copied from HA-core and adjusted
+# 20250613 Copied from HA-core and shell-check adjusted and modified for local use
 set -e
 
-my_path=$(git rev-parse --show-toplevel)
-
-if [ ! -n "$VIRTUAL_ENV" ]; then
+if [ -z "$VIRTUAL_ENV" ]; then
   if [ -x "$(command -v uv)" ]; then
     uv venv venv
   else

scripts/setup_test.sh

@@ -1,10 +1,10 @@
 #!/usr/bin/env bash
-# 20250613 Copied from HA-core and adjusted
+# 20250613 Copied from HA-core and shell-check adjusted and modified for local use
 set -e
 
 my_path=$(git rev-parse --show-toplevel)
 
-if [ ! -n "$VIRTUAL_ENV" ]; then
+if [ -z "$VIRTUAL_ENV" ]; then
   if [ -x "$(command -v uv)" ]; then
     uv venv venv
   else

scripts/tests_and_coverage.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env sh
+#!/usr/bin/env bash
 # 20250613 Copied from HA-Core: run-in-env.sh
 set -eu
 
@@ -15,13 +15,15 @@ if [ -s .python-version ]; then
 fi
 
 if [ -n "${VIRTUAL_ENV-}" ] && [ -f "${VIRTUAL_ENV}/bin/activate" ]; then
+  # shellcheck disable=SC1091 # ingesting virtualenv
   . "${VIRTUAL_ENV}/bin/activate"
 else
   # other common virtualenvs
   my_path=$(git rev-parse --show-toplevel)
 
   for venv in venv .venv .; do
     if [ -f "${my_path}/${venv}/bin/activate" ]; then
+      # shellcheck disable=SC1090 # ingesting virtualenv
       . "${my_path}/${venv}/bin/activate"
       break
     fi