Better names, remove logging

Author: bouwew

plugwise/helper.py

@@ -290,9 +290,9 @@ def __init__(self):
         """Set the constructor for this class."""
         self._appl_data: dict[str, Any] = {}
         self._appliances: etree | None = None
-        self._cao_present: bool = False
-        self._cao_temp: float | None = None
-        self._cdt_temp: float | None = None
+        self._anna_cooling_present: bool = False
+        self._cooling_activation_outdoor_temp: float | None = None
+        self._cooling_deactivation_threshold: float | None = None
         self._cooling_present = False
         self._devices: dict[str, str] = {}
         self._domain_objects: etree | None = None
@@ -626,11 +626,9 @@ def _all_appliances(self) -> None:
         ot_fault_code = self._appliances.find(
             ".//logs/point_log[type='open_therm_oem_fault_code']"
         )
-        LOGGER.debug("HOI1 %s, %s", c_heating_state, ot_fault_code)
         if c_heating_state is not None:
             self._opentherm_device = ot_fault_code is not None
             self._on_off_device = ot_fault_code is None
-        LOGGER.debug("HOI2 %s, %s", self._opentherm_device, self._on_off_device)
 
         for appliance in self._appliances.findall("./appliance"):
             appl = Munch()
@@ -689,8 +687,6 @@ def _all_appliances(self) -> None:
             ):
                 self._appl_data.pop(appl.dev_id)
 
-        LOGGER.debug("HOI3 %s", self._appl_data)
-
     def _match_locations(self) -> dict[str, Any]:
         """Helper-function for _scan_thermostats().
         Update locations with present appliance-types.
@@ -826,10 +822,10 @@ def _appliance_measurements(
                 # Anna: save cooling-related measurements for later use
                 # Use the local outdoor temperature as reference for turning cooling on/off
                 if measurement == "cooling_activation_outdoor_temperature":
-                    self._cao_present = self._cooling_present = True
-                    self._cao_temp = data.get(measurement)
+                    self._anna_cooling_present = self._cooling_present = True
+                    self._cooling_activation_outdoor_temp = data.get(measurement)
                 if measurement == "cooling_deactivation_threshold":
-                    self._cdt_temp = data.get(measurement)
+                    self._cooling_deactivation_threshold = data.get(measurement)
                 if measurement == "outdoor_temperature":
                     self._outdoor_temp = data.get(measurement)
 

plugwise/smile.py

@@ -56,7 +56,6 @@ def _all_device_data(self) -> None:
                 device_id, data, device, bs_dict, s_dict, sw_dict
             )
 
-        LOGGER.debug("HOI6 %s", self._cooling_present)
         self.gw_data["smile_name"] = self.smile_name
         self.gw_data["gateway_id"] = self.gateway_id
         if self._is_thermostat:
@@ -92,22 +91,18 @@ def get_all_devices(self) -> None:
         # Collect data for each device via helper function
         self._all_device_data()
 
-        LOGGER.debug("HOI4, %s", self._devices)
-        LOGGER.debug(
-            "HOI4a %s, %s, %s, %s",
-            self._outdoor_temp,
-            self._cao_present,
-            self._cao_temp,
-            self._cdt_temp,
-        )
-
         # Anna: indicate possible active heating/cooling operation-mode
         # Actual ongoing heating/cooling is shown via heating_state/cooling_state
-        if self._cao_present:
-            self._cooling_present = True
-            if not self.cooling_active and self._outdoor_temp > self._cao_temp:
+        if self._anna_cooling_present:
+            if (
+                not self.cooling_active
+                and self._outdoor_temp > self._cooling_activation_outdoor_temp
+            ):
                 self.cooling_active = True
-            if self.cooling_active and self._outdoor_temp < self._cdt_temp:
+            if (
+                self.cooling_active
+                and self._outdoor_temp < self._cooling_deactivation_threshold
+            ):
                 self.cooling_active = False
 
         # Don't show cooling_state when no cooling present
@@ -180,8 +175,6 @@ def _device_data_climate(
         if ctrl_state := self._control_state(loc_id):
             device_data["control_state"] = ctrl_state
 
-        LOGGER.debug("HOI5, %s, %s", details, device_data)
-
         # Operation mode: auto, heat, cool
         device_data["mode"] = "auto"
         if sel_schema == "None":