Revert _get_all_devices() changes

Author: bouwew

plugwise/helper.py

@@ -758,7 +758,7 @@ def _temperature_uri(self, loc_id):
         return f"{LOCATIONS};id={loc_id}/thermostat;id={thermostat_functionality_id}"
 
     def _group_switches(self):
-        """Helper-function for smile.py: _get_all_devices().
+        """Helper-function for smile.py: get_all_devices().
         Collect switching- or pump-group info.
         """
         switch_groups = {}

plugwise/smile.py

@@ -235,7 +235,7 @@ async def update_gw_devices(self):
                     self._update_helper(data, dev_dict, dev_id, "switches", key)
 
     def _all_device_data(self):
-        """Helper-function for _get_all_devices().
+        """Helper-function for get_all_devices().
         Collect initial data for each device and add to self.gw_devices.
         """
         dev_id_list = []
@@ -262,7 +262,7 @@ def _all_device_data(self):
 
         self.gw_devices = dict(zip(dev_id_list, dev_and_data_list))
 
-    def _get_all_devices(self):
+    def get_all_devices(self):
         """Determine the devices present from the obtained XML-data."""
         self._devices = {}
         self._scan_thermostats()

tests/test_smile.py

@@ -405,7 +405,7 @@ async def device_test(self, smile=pw_smile.Smile, testdata=None):
             "thermostatic_radiator_valve",
         ]
         bsw_lists = ["binary_sensors", "sensors", "switches"]
-        smile._get_all_devices()
+        smile.get_all_devices()
         await smile.update_gw_devices()
         device_list = smile.gw_devices
         self._write_json("all_devices", device_list)
@@ -1770,7 +1770,7 @@ async def test_connect_stretch_v31(self):
         _LOGGER.info(" # Assert no master thermostat")
         assert smile.single_master_thermostat() is None  # it's not a thermostat :)
 
-        smile._get_all_devices()
+        smile.get_all_devices()
         await self.device_test(smile, testdata)
 
         await smile.close_connection()
@@ -1820,7 +1820,7 @@ async def test_connect_stretch_v23(self):
         )
         assert switch_change
 
-        smile._get_all_devices()
+        smile.get_all_devices()
         await self.device_test(smile, testdata)
 
         await smile.close_connection()