Further checking and warnings

Author: CoMPaTech

requirements_commit.txt

@@ -3,8 +3,8 @@
 # Minimal requirements for committing
 # Versioning omitted (leave this up to HA-core)
 coverage
-flake8-black
+flake8-black==0.3.6
 mypy
 pre-commit
 pylint
-pylint_strict_informational
+pylint_strict_informational==0.1

requirements_test.txt

@@ -1,6 +1,6 @@
 # Import from setup.py
 -e .
 # Versioning omitted (leave this up to HA-core)
-pytest-asyncio==0.20.2
+pytest-asyncio
 radon==5.1.0
-types-python-dateutil==2.8.19.5
+types-python-dateutil

scripts/dependencies_check.sh

@@ -7,6 +7,9 @@
 #   - For everything *not* in use by HA-core we still would want dependabot to kick in appropriately
 #   - This script will exit with error if it finds 'unversioned' dependencies (as such should be part of our CI)
 
+# Default to non-error
+exitcode=0
+
 # Use local tmp
 if [ ! -d ./tmp ]; then
   mkdir -p ./tmp/urls
@@ -27,12 +30,16 @@ packages=$(grep -hEv "^$|^#|^\-e" ./requirements*.txt | cut -f 1 -d '=' | sort -
 
 # Check for local defined packages against upstream
 pkglist="./tmp/pkglist"
+pkgredundant="./tmp/pkgredundant"
 true > "${pkglist}"
+true > "${pkgredundant}"
 for pkg in ${packages}; do
   # shellcheck disable=SC2046,SC2143
   if [ ! $(grep -rhE "^${pkg}" ./tmp/urls) ]; then
 #    echo "${pkg} not in upstream requirements/constraints"
     echo "${pkg}" >> "${pkglist}"
+  else
+    echo "${pkg}" >> "${pkgredundant}"
   fi
 done
 
@@ -48,13 +55,53 @@ for pkg in $(sort -u ${pkglist}); do
   fi
 done
 
+# Check for versioning in setup.py
+pkgpy=$(sed -n '/install_requires=\[/,/\]/p' setup.py | tr -d '\n' | sed 's/^.*\[\(.*\)\].*$/\1/g' | tr -d ',"')
+for pkgfull in ${pkgpy}; do
+  # Very ugly multi-character split
+  # shellcheck disable=SC3011
+  pkg=$(cut -d '=' -f 1 <<< "${pkgfull}" | cut -d '<' -f 1 | cut -d '>' -f 1)
+  # shellcheck disable=SC2046,SC2143
+  if [ ! $(grep -qrhE "^${pkg}" ./tmp/urls) ]; then
+#    echo "DEBUG:   ${pkg} from setup.py not in upstream requirements/constraints"
+    if [ ! $(grep -rhE "^${pkg}==" ./requirements*.txt) ]; then
+#      echo "DEBUG:   ${pkg} from setup.py not in local requirements"
+      # shellcheck disable=SC3014
+      if [ "${pkg}" == "${pkgfull}" ]; then
+        echo "WARNING: ${pkg} not in any requirements and no version specified in setup.py"
+#      else
+#        echo "DEBUG:   ${pkg} version specified in setup.py"
+      fi
+#    else
+#      echo "DEBUG:   ${pkg} found in local requirements"
+    fi
+#  else
+#    echo "DEBUG:   ${pkg} found in upstream URLs"
+  fi
+done
+echo ""
+
+# Print redundant information (no error value)
+# shellcheck disable=SC2046
+#if [ $(wc -l "${pkgmiss}" | awk '{print $1}') -gt 0 ]; then
+  echo "INFO:    Packages redundant with upstream:"
+  # shellcheck disable=SC2013
+  for pkg in $(sort -u ${pkgredundant}); do
+    echo "INFO:      ${pkg} in ($(grep -hlE "^${pkg}" ./requirements*.txt)) already avavilable via $(grep -rhlE "^${pkg}" ./tmp/urls/)"
+  done
+  echo ""
+#fi
+
 # Print missing information and exit error out
 # shellcheck disable=SC2046
 if [ $(wc -l "${pkgmiss}" | awk '{print $1}') -gt 0 ]; then
-  echo "Packages missing from local requirements_*.txt files:"
+  echo "ERROR:  Packages missing from local requirements_*.txt files:"
   # shellcheck disable=SC2013
   for pkg in $(sort -u ${pkgmiss}); do
-    echo "  ${pkg} in $(grep -hlE "^${pkg}" ./requirements*.txt) missing version information"
+    echo "INFO:     ${pkg} in $(grep -hlE "^${pkg}" ./requirements*.txt) missing version information"
   done
-  exit 1
+  echo ""
+  exitcode=1
 fi
+
+exit ${exitcode}