Move smile() to common.py

Author: bouwew

plugwise/common.py

@@ -0,0 +1,17 @@
+"""Use of this source code is governed by the MIT license found in the LICENSE file.
+
+Plugwise Smile protocol helpers.
+"""
+from __future__ import annotations
+
+
+class SmileCommon:
+    """The SmileCommon class."""
+
+    def __init__(self) -> None:
+        """Init."""
+        self.smile_name: str
+
+    def smile(self, name: str) -> bool:
+        """Helper-function checking the smile-name."""
+        return self.smile_name == name

plugwise/helper.py

@@ -8,6 +8,7 @@
 import datetime as dt
 from typing import cast
 
+from plugwise.common import SmileCommon
 from plugwise.constants import (
     ACTIVE_ACTUATORS,
     ACTUATOR_CLASSES,
@@ -191,7 +192,7 @@ async def close_connection(self) -> None:
         await self._websession.close()
 
 
-class SmileHelper:
+class SmileHelper(SmileCommon):
     """The SmileHelper class."""
 
     def __init__(self) -> None:
@@ -248,10 +249,7 @@ def __init__(self) -> None:
         self.smile_type: str
         self.smile_zigbee_mac_address: str | None
         self.therms_with_offset_func: list[str] = []
-
-    def smile(self, name: str) -> bool:
-        """Helper-function checking the smile-name."""
-        return self.smile_name == name
+        SmileCommon.__init__(self)
 
     def _all_locations(self) -> None:
         """Collect all locations."""

plugwise/legacy/helper.py

@@ -7,6 +7,7 @@
 import datetime as dt
 from typing import cast
 
+from plugwise.common import SmileCommon
 from plugwise.constants import (
     ACTIVE_ACTUATORS,
     ACTUATOR_CLASSES,
@@ -67,7 +68,7 @@ def etree_to_dict(element: etree) -> dict[str, str]:
     return node
 
 
-class SmileLegacyHelper:
+class SmileLegacyHelper(SmileCommon):
     """The SmileLegacyHelper class."""
 
     def __init__(self) -> None:
@@ -101,10 +102,7 @@ def __init__(self) -> None:
         self.smile_name: str
         self.smile_type: str
         self.smile_zigbee_mac_address: str | None
-
-    def smile(self, name: str) -> bool:
-        """Helper-function checking the smile-name."""
-        return self.smile_name == name
+        SmileCommon.__init__(self)
 
     def _all_locations(self) -> None:
         """Collect all locations."""