Implement _get_groups() enhancement as suggested

bouwew · bouwew · commit 995d57768d21 · 2025-12-25T12:41:58.000+01:00
diff --git a/plugwise/common.py b/plugwise/common.py
@@ -230,6 +230,9 @@ def _get_groups(self) -> None:
                     "vendor": "Plugwise",
                 }
                 self._count += 5
+            elif group_id in self._existing_groups:
+                # Group existed but now has no valid members ->  remove
+                self._new_groups.remove(group_id)
 
         removed = list(set(self._existing_groups) - set(self._new_groups))
         if self._existing_groups and removed:

Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,9 @@ def _get_groups(self) -> None:`
`230`	`230`	`"vendor": "Plugwise",`
`231`	`231`	`}`
`232`	`232`	`self._count += 5`
	`233`	`+ elif group_id in self._existing_groups:`
	`234`	`+ # Group existed but now has no valid members -> remove`
	`235`	`+ self._new_groups.remove(group_id)`
`233`	`236`
`234`	`237`	`removed = list(set(self._existing_groups) - set(self._new_groups))`
`235`	`238`	`if self._existing_groups and removed:`